require a local write time in IsServerTimestamp

[isl-Ramzi]

IsServerTimestamp classifies any small map holding __type__: "server_timestamp" as a server timestamp sentinel, looking only at the __type__ key. A real sentinel is only produced by EncodeServerTimestamp, which also writes a __local_write_time__ timestamp, but an ordinary document field a client writes can carry that same key on its own. When such a value is read back and compared, GetTypeOrder routes it to TypeOrder::kServerTimestamp and Compare/Equals call GetLocalWriteTime, which HARD_FAILs because the write time it assumes is missing. Require both the sentinel and a timestamp-typed __local_write_time__ before classifying the value, so those user maps stay maps while genuine sentinels are unaffected.

[gemini-code-assist]

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.