feat: add ExtendSectorExpiration3 to update the existing sectors to 10x QAP - #1775
feat: add ExtendSectorExpiration3 to update the existing sectors to 10x QAP#1775akaladarshi wants to merge 4 commits into
ExtendSectorExpiration3 to update the existing sectors to 10x QAP#1775Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fix/fips1249-1744-review-fixes #1775 +/- ##
==================================================================
- Coverage 88.22% 88.17% -0.05%
==================================================================
Files 140 140
Lines 26555 26817 +262
==================================================================
+ Hits 23428 23646 +218
- Misses 3127 3171 +44
🚀 New features to boost your workflow:
|
|
I am continuing the work on the testing and some changes, but It would be great to have a first review on this, so we can align on the required changes. |
| SectorOnChainInfoFlags::SIMPLE_QA_POWER | SectorOnChainInfoFlags::FULL_QA_POWER; | ||
|
|
||
| // Pledge for the upgraded power, never lowered below what is already held. | ||
| new_sector.initial_pledge = max(new_sector.initial_pledge, full_power_pledge.clone()); |
There was a problem hiding this comment.
needs a FULL_QA_POWER around this, don't ratchet it up for already-upgraded sectors; FIP says "raised at most once"
| for decl in ¶ms.extensions { | ||
| for sector_number in decl.sectors.iter() { | ||
| emit::sector_updated(rt, sector_number, None, &[])?; | ||
| } | ||
| } |
There was a problem hiding this comment.
Two things here: 1) they're not emitted the deduped list so you could get duplicate events. But more importantly 2) this is a snap event that comes out of PRU3 and isn't appropriate for extensions. So for now let's remove events entirely because I want to have that discussion separately.
| sector: &SectorOnChainInfo, | ||
| sector_size: SectorSize, | ||
| circulating_supply: &TokenAmount, | ||
| full_qa_power: &StoragePower, |
There was a problem hiding this comment.
| full_qa_power: &StoragePower, |
you only use this after you set the flags to make full QA be max QA, so it's not variable, it's just qa_power_max
|
@akaladarshi see items in #1763, I think mostly we've got resolution. Getting near-enough for now would be good and if there are outstanding details or tweaks we can do them on top of this later. |
ExtendSectorExpiration3in the miner actor.ExtendSectorExpiration3updates the existing active sectors to the 10x QAP.ExtendSectorExpiration3Paramsacceptsnew_expirationwhich is an optional value and it allows the method to extended the sectors if set to some value.This PR is assisted by Claude code (Fable and Opus5)