fix(core): implement network boundary security for agent endpoints#874
Open
RinZ27 wants to merge 1 commit into
Open
fix(core): implement network boundary security for agent endpoints#874RinZ27 wants to merge 1 commit into
RinZ27 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR implements a first-line defense against SSRF by introducing an IP denylist in the
AlmanacResolver. It ensures that agent endpoints resolved via the Almanac API do not point to private, loopback, link-local, or cloud metadata IP addresses (RFC 1918).Key changes:
is_safe_urlhelper inresolver.pyusing Python's standardipaddresslibrary.lookup_endpoint_for_agentto filter out unsafe endpoints.Linked Issues
Fixes #854
Types of changes
Checklist
Further comments
While there are ongoing discussions regarding a more comprehensive security middleware and trust gate architectures (e.g., #865), this IP denylisting provides immediate protection against common SSRF vectors. It blocks access to internal resources like
169.254.169.254and local admin interfaces by default.Verified the logic with test cases covering: