auth/oidc: Add support for static JWKS and PEM key verification in OIDC - #5260
auth/oidc: Add support for static JWKS and PEM key verification in OIDC#5260johnvox wants to merge 10 commits into
Conversation
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (1 file)
Fix these issues in Kilo Cloud Reviewed by gpt-5.5-2026-04-23 · 394,710 tokens |
|
PRs go stale after 14d of inactivity. Stale PRs rot after an additional 3d of inactivity and eventually close. |
|
/not stale |
|
PRs go stale after 14d of inactivity. Stale PRs rot after an additional 3d of inactivity and eventually close. |
|
/not stale |
|
Hi, NewTokenVerifierFromStatic can call DecodeJWKS with a nil *JSONWebKeySet, which dereferences jwks.Keys and panics, potentially crashing the server at startup when the dynamic provider lookup fails and static config is incomplete. Severity: action required | Category: reliability How to fix: Validate IssuerSpec and nil-check Agent prompt to fix - you can give this to your LLM of choice:
We noticed a couple of other issues in this PR as well - happy to share if helpful. Found by Qodo code review |
Handle Qodo-Free-For-OSS comment
|
PRs go stale after 14d of inactivity. Stale PRs rot after an additional 3d of inactivity and eventually close. |
|
/not stale |
|
@fatedier could you please consider review thanks |
|
PRs go stale after 14d of inactivity. Stale PRs rot after an additional 3d of inactivity and eventually close. |
|
/not stale |
|
PRs go stale after 14d of inactivity. Stale PRs rot after an additional 3d of inactivity and eventually close. |
|
/not stale |
|
PRs go stale after 14d of inactivity. Stale PRs rot after an additional 3d of inactivity and eventually close. |
|
Not stale
Le sam. 18 juil. 2026, 02:51, github-actions[bot] ***@***.***>
a écrit :
… *github-actions[bot]* left a comment (fatedier/frp#5260)
<#5260 (comment)>
PRs go stale after 14d of inactivity. Stale PRs rot after an additional 3d
of inactivity and eventually close.
—
Reply to this email directly, view it on GitHub
<#5260?email_source=notifications&email_token=AALKX2JKDATJNF2PGOQAHC35FLCYRA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBQHA4TINZQGA22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-5008947005>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALKX2KQMTINULCBSVLAJBT5FLCYRAVCNFSNUABEKJSXA33TNF2G64TZHM2DQMZXHA4TINZ3JFZXG5LFHM2DCMRQHAYDMMRWHCQXMAQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
PRs go stale after 14d of inactivity. Stale PRs rot after an additional 3d of inactivity and eventually close. |
|
Not stale
Le dim. 2 août 2026, 02:59, github-actions[bot] ***@***.***>
a écrit :
… *github-actions[bot]* left a comment (fatedier/frp#5260)
<#5260 (comment)>
PRs go stale after 14d of inactivity. Stale PRs rot after an additional 3d
of inactivity and eventually close.
—
Reply to this email directly, view it on GitHub
<#5260?email_source=notifications&email_token=AALKX2PH3BCETAAIGBYUTS35H2G5LA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMJVGQZTANBTGQ42M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-5154304349>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALKX2ILCTBLNQLDRZ5ZTQ35H2G5LAVCNFSNUABEKJSXA33TNF2G64TZHM2DQMZXHA4TINZ3JFZXG5LFHM2DCMRQHAYDMMRWHCQXMAQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
WHY
This PR introduces support for static key verification in the OIDC authentication flow, allowing the use of JWKS (JSON Web Key Set) and PEM-encoded certificates/public keys as alternatives to dynamic OIDC provider-based verification.
Enables OIDC token verification in offline or restricted environments.
New Configuration:
Here Config Snippet used during dev