fix(qonnx): handle scalar zpt for per-tensor bias quantization#238
Open
narutozxp wants to merge 1 commit into
Open
fix(qonnx): handle scalar zpt for per-tensor bias quantization#238narutozxp wants to merge 1 commit into
narutozxp wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Conv bias quantization is enabled with per-tensor quantization, exported QONNX models may not always use the same shape representation for scale and zero-point. The scale may be stored as (1,), while the zero-point may be stored as ().
The previous logic relied on shape comparison against (1,), which could fail to catch this scalar zero-point representation. If this case is not handled explicitly, the subsequent reshape operation can fail because the zero-point shape is not normalized to the expected per-tensor form.
This PR makes the check semantically correct by treating both forms as valid per-tensor quantization parameters.