docs: add type hints to examples (things.py, things_asgi.py, things_advanced_asgi.py)#2639
Open
Midhun1618 wants to merge 3 commits into
Open
docs: add type hints to examples (things.py, things_asgi.py, things_advanced_asgi.py)#2639Midhun1618 wants to merge 3 commits into
Midhun1618 wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2639 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 64
Lines 7976 7976
Branches 1102 1102
=========================================
Hits 7976 7976 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Added type annotations to three example files as part of #1820:
examples/things.py— addedfrom falcon import Request, Responseand typed theon_getresponderexamples/things_asgi.py— addedfrom falcon.asgi import Request, Responseand typed theon_getresponderexamples/things_advanced_asgi.py— addedfrom falcon.asgi import Request, Responseandfrom typing import Any, typed all responder methods, middleware process methods, hook functions, and helper methods throughoutRelated Issues
#1820
Pull Request Checklist
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. Reading our contribution guide at least once will save you a few review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.
tox.docs/.docs/.versionadded,versionchanged, ordeprecateddirectives.docs/_newsfragments/.