Make AC Video JEPA wandb logging robust when disabled#25
Conversation
|
Hi @zuiailaoyouji! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary
This PR makes W&B logging in
examples/ac_video_jepa/main.pyrobust when W&B is disabled or not initialized.I encountered a crash when running AC Video JEPA with W&B explicitly disabled:
CUDA_VISIBLE_DEVICES=0 WANDB_DISABLED=true python -m examples.ac_video_jepa.main \ --fname examples/ac_video_jepa/cfgs/train.yaml \ --logging.log_wandb falseThe run still reached a
wandb.log(...)call and failed with:This indicates that some W&B logging calls can be executed even when no W&B run has been initialized.
This PR fixes the issue by:
use_wandb = wandb_run is not None;wandb.log(...)calls withwandb_run.log(...);if use_wandb;Motivation
The script should not call
wandb.log(...)unless W&B has actually been initialized.This is especially important for offline servers or local reproduction environments where users may disable W&B using
WANDB_DISABLED=trueor--logging.log_wandb false.Using
wandb_run is not Noneas the logging guard is more robust than relying only on the config value.Testing
After this change, I reran the same command:
CUDA_VISIBLE_DEVICES=0 WANDB_DISABLED=true python -m examples.ac_video_jepa.main \ --fname examples/ac_video_jepa/cfgs/train.yaml \ --logging.log_wandb falseThe script no longer crashes with the W&B initialization error.