Skip to content

Make AC Video JEPA wandb logging robust when disabled#25

Open
zuiailaoyouji wants to merge 1 commit into
facebookresearch:mainfrom
zuiailaoyouji:fix-ac-video-jepa-wandb-disabled
Open

Make AC Video JEPA wandb logging robust when disabled#25
zuiailaoyouji wants to merge 1 commit into
facebookresearch:mainfrom
zuiailaoyouji:fix-ac-video-jepa-wandb-disabled

Conversation

@zuiailaoyouji

Copy link
Copy Markdown

Summary

This PR makes W&B logging in examples/ac_video_jepa/main.py robust when W&B is disabled or not initialized.

I encountered a crash when running AC Video JEPA with W&B explicitly disabled:

CUDA_VISIBLE_DEVICES=0 WANDB_DISABLED=true python -m examples.ac_video_jepa.main \
  --fname examples/ac_video_jepa/cfgs/train.yaml \
  --logging.log_wandb false

The run still reached a wandb.log(...) call and failed with:

wandb.errors.Error: You must call wandb.init() before wandb.log()

This indicates that some W&B logging calls can be executed even when no W&B run has been initialized.

This PR fixes the issue by:

  • introducing use_wandb = wandb_run is not None;
  • replacing direct wandb.log(...) calls with wandb_run.log(...);
  • guarding W&B logging with if use_wandb;
  • propagating the effective W&B logging state to the planning evaluation config.

Motivation

The script should not call wandb.log(...) unless W&B has actually been initialized.

This is especially important for offline servers or local reproduction environments where users may disable W&B using WANDB_DISABLED=true or --logging.log_wandb false.

Using wandb_run is not None as the logging guard is more robust than relying only on the config value.

Testing

After this change, I reran the same command:

CUDA_VISIBLE_DEVICES=0 WANDB_DISABLED=true python -m examples.ac_video_jepa.main \
  --fname examples/ac_video_jepa/cfgs/train.yaml \
  --logging.log_wandb false

The script no longer crashes with the W&B initialization error.

@meta-cla

meta-cla Bot commented Jul 2, 2026

Copy link
Copy Markdown

Hi @zuiailaoyouji!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jul 2, 2026
@meta-cla

meta-cla Bot commented Jul 2, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant