Skip to content

Add checked shift and allocation size validation in COVER_map_init()

6337ee7
Select commit
Loading
Failed to load commit list.
Open

Add checked shift and allocation size validation in COVER_map_init() #4627

Add checked shift and allocation size validation in COVER_map_init()
6337ee7
Select commit
Loading
Failed to load commit list.
Cirrus CI / FreeBSD (make check) failed Mar 18, 2026 in 36s

Task Summary

Instruction main failed in 00:20

Details

✅ 00:13 clone
✅ 00:01 install
❌ 00:20 main

CC obj/conf_83f08fd8c372e4b935c5f7dffa68bced/static/zstd_decompress_block.o
CC obj/conf_788d2a922d9a63000c483dbc7b112b32/dynamic/pool.o
AS obj/conf_83f08fd8c372e4b935c5f7dffa68bced/static/huf_decompress_amd64.o
CC obj/conf_788d2a922d9a63000c483dbc7b112b32/dynamic/threading.o
CC obj/conf_788d2a922d9a63000c483dbc7b112b32/dynamic/xxhash.o
CC obj/conf_83f08fd8c372e4b935c5f7dffa68bced/static/cover.o
CC obj/conf_788d2a922d9a63000c483dbc7b112b32/dynamic/zstd_common.o
CC obj/conf_788d2a922d9a63000c483dbc7b112b32/dynamic/fse_compress.o
CC obj/conf_83f08fd8c372e4b935c5f7dffa68bced/static/divsufsort.o
CC obj/conf_788d2a922d9a63000c483dbc7b112b32/dynamic/hist.o
CC obj/conf_83f08fd8c372e4b935c5f7dffa68bced/static/fastcover.o
CC obj/conf_788d2a922d9a63000c483dbc7b112b32/dynamic/huf_compress.o
CC obj/conf_83f08fd8c372e4b935c5f7dffa68bced/static/zdict.o
CC obj/conf_788d2a922d9a63000c483dbc7b112b32/dynamic/zstd_compress.o
CC obj/conf_788d2a922d9a63000c483dbc7b112b32/dynamic/zstd_compress_literals.o
CC obj/conf_788d2a922d9a63000c483dbc7b112b32/dynamic/zstd_compress_sequences.o
CC obj/conf_788d2a922d9a63000c483dbc7b112b32/dynamic/zstd_compress_superblock.o
CC obj/conf_788d2a922d9a63000c483dbc7b112b32/dynamic/zstd_double_fast.o
CC obj/conf_788d2a922d9a63000c483dbc7b112b32/dynamic/zstd_fast.o
/tmp/cirrus-ci-build/lib//dictBuilder/cover.c:169:13: error: mixing declarations and code is incompatible with standards before C99 [-Werror,-Wdeclaration-after-statement]
  169 |   U32 const sizeLog = ZSTD_CC obj/conf_788d2a922d9a63000c483dbc7b112b32/dynamic/zstd_lazy.o
highbCC obj/conf_788d2a922d9a63000c483dbc7b112b32/dynamic/zstd_ldm.o
it32CC obj/conf_788d2a922d9a63000c483dbc7b112b32/dynamic/zstd_opt.o
(CC obj/conf_788d2a922d9a63000c483dbc7b112b32/dynamic/zstdmt_compress.o
sCC obj/conf_788d2a922d9a63000c483dbc7b112b32/dynamic/zstd_preSplit.o
izCC obj/conf_788d2a922d9a63000c483dbc7b112b32/dynamic/huf_decompress.o
eCC obj/conf_788d2a922d9a63000c483dbc7b112b32/dynamic/zstd_ddict.o
) + 2;CC obj/conf_788d2a922d9a63000c483dbc7b112b32/dynamic/zstd_decompress_block.o

      AS obj/conf_788d2a922d9a63000c483dbc7b112b32/dynamic/huf_decompress_amd64.o
CC obj/conf_788d2a922d9a63000c483dbc7b112b32/dynamic/zstd_decompress.o
|             ^
CC obj/conf_788d2a922d9a63000c483dbc7b112b32/dynamic/cover.o
1 error generated.
CC obj/conf_788d2a922d9a63000c483dbc7b112b32/dynamic/divsufsort.o
gmake[2]: *** [Makefile:222: obj/conf_83f08fd8c372e4b935c5f7dffa68bced/static/cover.o] Error 1
CC obj/conf_788d2a922d9a63000c483dbc7b112b32/dynamic/fastcover.o
/tmp/cirrus-ci-build/lib//dictBuilder/cover.c:CC obj/conf_788d2a922d9a63000c483dbc7b112b32/dynamic/zdict.o
gmake[2]: *** Waiting for unfinished jobs....
169:13: error: mixing declarations and code is incompatible with standards before C99 [-Werror,-Wdeclaration-after-statement]
  169 |   U32 const sizeLog = ZSTD_highbit32(size) + 2;
      |             ^
1 error generated.
gmake[2]: *** [Makefile:218: obj/conf_788d2a922d9a63000c483dbc7b112b32/dynamic/cover.o] Error 1
gmake[2]: *** Waiting for unfinished jobs....
echo "Update zstd manual in /doc"
Update zstd manual in /doc
./gen_html 1.6.0 ../../lib/zstd.h ../../doc/zstd_manual.html
gmake[1]: Leaving directory '/tmp/cirrus-ci-build/contrib/gen_html'
gmake[1]: *** [Makefile:154: libzstd.so.1.6.0] Error 2
gmake[1]: *** Waiting for unfinished jobs....
gmake[1]: *** [Makefile:113: libzstd.a] Error 2
gmake[1]: Leaving directory '/tmp/cirrus-ci-build/lib'
gmake: *** [Makefile:63: lib] Error 2

Exit status: 2