Skip to content

Fix #36525: DevTools Profiler 'What changed' context scrolls out of view#36532

Open
Jefsky wants to merge 1 commit into
facebook:mainfrom
Jefsky:main
Open

Fix #36525: DevTools Profiler 'What changed' context scrolls out of view#36532
Jefsky wants to merge 1 commit into
facebook:mainfrom
Jefsky:main

Conversation

@Jefsky
Copy link
Copy Markdown

@Jefsky Jefsky commented May 24, 2026

Bug Description

When inspecting a fiber with a long render history (many commits) in the React DevTools Profiler, scrolling through the commit list to inspect individual renders causes the 'Why did this render?' (WhatChanged) section to scroll out of view. This makes it difficult to reference why a component rendered while navigating through commits.

Root Cause

The 'Rendered at:' commit list and the 'Why did this render?' section are both placed in a scrollable column container. When the commit list grows long, it pushes the WhatChanged content out of the visible area.

Fix

Wrap the commit list in a container with flex: 0 0 auto so it takes only the space it needs and doesn't push the WhatChanged section out of view. The WhatChanged section stays fixed at the top while users navigate commits below.

Before: The commit list and WhatChanged content compete for the same flex space, causing WhatChanged to scroll away.

After: The commit list is self-sizing and doesn't push WhatChanged out of view.

Closes #36525

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented May 24, 2026

Hi @Jefsky!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla Bot added the CLA Signed label May 24, 2026
@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented May 24, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DevTools Bug]: Profiler's "What changed" context becomes unusable when inspecting commits with long render histories

1 participant