Skip to content

perf(react-dom): bound server style name cache#36479

Open
leno23 wants to merge 1 commit into
facebook:mainfrom
leno23:perf/bound-ssr-style-name-cache
Open

perf(react-dom): bound server style name cache#36479
leno23 wants to merge 1 commit into
facebook:mainfrom
leno23:perf/bound-ssr-style-name-cache

Conversation

@leno23
Copy link
Copy Markdown

@leno23 leno23 commented May 16, 2026

Summary

This bounds the module-level styleNameCache used by processStyleName in the React DOM server renderer.

The cache normally contains a small fixed set of style property names, but it is currently unbounded for the lifetime of a long-running SSR process. This change clears the cache if it grows beyond 1024 unique keys, preserving the existing fast path for normal cases while avoiding pathological retention of unbounded user-generated style names.

Test Plan

  • Not run locally yet; opening as draft for initial feedback.
  • Intended checks before marking ready:
    • yarn test packages/react-dom
    • relevant React DOM server/Fizz tests
    • microbenchmark if maintainers want data for the cache cap tradeoff

Notes

I chose a simple clear-on-limit strategy instead of LRU to avoid adding per-access overhead to the hot path.

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented May 16, 2026

Hi @leno23!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@leno23 leno23 marked this pull request as ready for review May 16, 2026 04:45
@leno23 leno23 marked this pull request as draft May 16, 2026 04:52
@leno23 leno23 marked this pull request as ready for review May 16, 2026 04:54
@leno23 leno23 marked this pull request as draft May 16, 2026 05:32
@leno23 leno23 marked this pull request as ready for review May 16, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant