[Accton][minipack3bam] platform: Add NETLAKE2 PVT versioned support#1378
Open
brandonchuang wants to merge 1 commit into
Open
[Accton][minipack3bam] platform: Add NETLAKE2 PVT versioned support#1378brandonchuang wants to merge 1 commit into
brandonchuang wants to merge 1 commit into
Conversation
Summary:
Add versioned configuration support for NETLAKE2 PVT on the minipack3bam platform.
NETLAKE2 PVT boards use different voltage regulator (VR) sources depending on the hardware sub-version.
This change introduces per-version configs in both `platform_manager` and `sensor_service` to
ensure proper initialization and sensor monitoring across all variants.
Changes:
platform_manager:
Added a new `VersionedPmUnitConfig` entry with `productSubVersion: 3` (Renesas) for the COMESE_SLOT PM unit.
- Registers `raa228228` VR devices (COME_VOLTAGE_MONITOR1/2), `ina230`, `tmp75` temperature sensors, and `spd5118` DIMM thermal sensors.
- Version-to-VR mapping: productSubVersion 1 (Infineon), 2 (MPS), 3 (Renesas)
sensor_service:
Introduced `versionedSensors` entries (keyed by `respinVariantIndicator`) to distinguish sensor sysfsPath differences among NETLAKE2 VR variants:
- `respinVariantIndicator: 1` → v3.1.1 (Infineon) — uses `power2/in2/curr2` and `power3/in3/curr3` channels
- `respinVariantIndicator: 2` → v3.1.2 (MPS) — uses `power3/in2/curr3` and `power4/in3/curr4` channels
- `respinVariantIndicator: 3` → v3.1.3 (Renesas) — uses `power3/in3/curr3` and `power4/in4/curr4` channels
Updated DIMM temperature sensor thresholds per vendor guidance:
- `COME_JCN1A_DIMM_CHA_TEMP` and `COME_JCN2A_DIMM_CHB_TEMP`:
- `upperCriticalVal` changed from 80 to 85.
- Removed `maxAlarmVal` and `minAlarmVal` — per vendor, lower critical/min/max thresholds are N/A
because protection and warning SELs should be configured for the upper side of the temperature range only.
Dependencies:
Kernel config `CONFIG_SENSORS_ISL68137` must be enabled (provides `raa228228` hwmon driver for Renesas VR).
Test Plan:
Hardware Verification — Verified on minipack3bam devices equipped with each NETLAKE2 variant:
1. COME EEPROM verification (`weutil -eeprom COME`) — Confirmed hardware identity for each DUT:
- All boards report: Product Name `NETLAKE20`, Production State `PVT`, Production Sub-State `1`
- `Re-Spin/Variant Indicator: 1` → v3.1.1 (Infineon)
- `Re-Spin/Variant Indicator: 2` → v3.1.2 (MPS)
- `Re-Spin/Variant Indicator: 3` → v3.1.3 (Renesas)
2. platform_manager started and initialized correctly on all versions.
3. platform_manager_hw_test — All test cases passed.
4. sensor_service correctly resolved versioned configs:
- Resolved to `versionedPmSensors` (v3.1.1 / v3.1.2 / v3.1.3) for NETLAKE2 at `/SCM_SLOT@0/COMESE_SLOT@0`
5. sensor_service_hw_test — All test cases passed.
6. sensor_service_client — All test cases passed.
brandonchuang
force-pushed
the
mp3bam_nl2_pvt
branch
from
da35bcf to
b8fa87d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runclang-format.........................................(no files to check)Skipped
shellcheck...........................................(no files to check)Skipped
shfmt................................................(no files to check)Skipped
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check json...............................................................Passed
check for merge conflicts................................................Passed
ruff check...........................................(no files to check)Skipped
ruff format..........................................(no files to check)Skipped
Prevent sai_impl in fboss manifest.......................................Passed
Summary
Add versioned configuration support for NETLAKE2 PVT on the minipack3bam platform.
NETLAKE2 PVT boards use different voltage regulator (VR) sources depending on the hardware sub-version.
This change introduces per-version configs in both
platform_managerandsensor_serviceto ensure proper initialization and sensor monitoring across all variants.Changes
platform_manager:
VersionedPmUnitConfigentry withproductSubVersion: 3(Renesas) for the COMESE_SLOT PM unit.raa228228VR devices (COME_VOLTAGE_MONITOR1/2),ina230,tmp75temperature sensors, andspd5118DIMM thermal sensors.sensor_service:
versionedSensorsentries (keyed byrespinVariantIndicator) to distinguish sensor sysfsPath differences among NETLAKE2 VR variants:respinVariantIndicator: 1→ v3.1.1 (Infineon) — usespower2/in2/curr2andpower3/in3/curr3channelsrespinVariantIndicator: 2→ v3.1.2 (MPS) — usespower3/in2/curr3andpower4/in3/curr4channelsrespinVariantIndicator: 3→ v3.1.3 (Renesas) — usespower3/in3/curr3andpower4/in4/curr4channelsDependencies
CONFIG_SENSORS_ISL68137must be enabled (providesraa228228hwmon driver for Renesas VR).Test Plan
Hardware Verification — Verified on minipack3bam devices equipped with each NETLAKE2 variant:
COME EEPROM verification (
weutil -eeprom COME) — Confirmed hardware identity for each DUT:NETLAKE20, Production StatePVT, Production Sub-State1Re-Spin/Variant Indicator: 1→ v3.1.1 (Infineon)Re-Spin/Variant Indicator: 2→ v3.1.2 (MPS)Re-Spin/Variant Indicator: 3→ v3.1.3 (Renesas)mp3bam_weutil_come_come_3.1.1.txt
mp3bam_weutil_come_come_3.1.2.txt
mp3bam_weutil_come_come_3.1.3.txt
platform_manager started and initialized correctly on all versions.
mp3bam_platform_manager_come_3.1.1.txt
mp3bam_platform_manager_come_3.1.2.txt
mp3bam_platform_manager_come_3.1.3.txt
platform_manager_hw_test — All test cases passed.
mp3bam_platform_manager_hw_test_come_3.1.1.txt
mp3bam_platform_manager_hw_test_come_3.1.2.txt
mp3bam_platform_manager_hw_test_come_3.1.3.txt
sensor_service correctly resolved versioned configs:
versionedPmSensors(v3.1.1 / v3.1.2 / v3.1.3) for NETLAKE2 at/SCM_SLOT@0/COMESE_SLOT@0mp3bam_sensor_service_come_3.1.1.txt
mp3bam_sensor_service_come_3.1.2.txt
mp3bam_sensor_service_come_3.1.3.txt
sensor_service_hw_test — All test cases passed.
mp3bam_sensor_service_hw_test_come_3.1.1.txt
mp3bam_sensor_service_hw_test_come_3.1.2.txt
mp3bam_sensor_service_hw_test_come_3.1.3.txt
sensor_service_client — All test cases passed.
mp3bam_sensor_service_client_come_3.1.1.txt
mp3bam_sensor_service_client_come_3.1.2.txt
mp3bam_sensor_service_client_come_3.1.3.txt