[Nexthop][M4062nhp] Add service configs#1375
Open
anna-nexthop wants to merge 1 commit into
Open
Conversation
Add the remaining platform-service configs for the M4062NHP platform: - sensor_service.json — sensor source paths, types, and thresholds consumed by sensor_service - fan_service.json — fan control zones (PWM/RPM sysfs paths, PID/setpoints) consumed by fan_service - led_manager.json — system and per-FRU LED sysfs paths plus presence detection consumed by data_corral_service - fw_util.json — firmware version/programming entries consumed by fw_util weutil and platform_manager are already served by the committed platform_manager.json. Test Plan: Each JSON parses and conforms to its platform config thrift type. Schema validity is enforced at config_lib build time, where ConfigGenerator runs the per-service ConfigValidator (and CrossConfigValidator) over every committed config. Additionally, commands `sensor_service_client`, `weutil --all`, `fw_util` all return the expected output.
anna-nexthop
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Add the remaining platform-service configs for the M4062NHP platform:
weutil and platform_manager are already served by the committed platform_manager.json.
Test Plan
Each JSON parses and conforms to its platform config thrift type. Schema validity is enforced at config_lib build time, where ConfigGenerator runs the per-service ConfigValidator (and CrossConfigValidator) over every committed config. Additionally, commands
sensor_service_client,weutil --all,fw_utilall return the expected output.