[Cisco] Reduce VerifySingleWRRAndNC runtime by flooding only competing queues.#1371
Open
ram316583 wants to merge 1 commit into
Open
[Cisco] Reduce VerifySingleWRRAndNC runtime by flooding only competing queues.#1371ram316583 wants to merge 1 commit into
ram316583 wants to merge 1 commit into
Conversation
Remove redundant pre-send and pass the per-iteration WRR+SP queue pair to verifySPHelper instead of all queues, avoiding duplicate packet injection.
ram316583
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Speed up VerifySingleWRRAndNC test by removing duplicate traffic injection in verifySingleWRRAndSP and passing only the per-iteration WRR+SP queue pair to verifySPHelper instead of all queues.
Test Plan
Manually ran AgentOlympicQosSchedulerTest.VerifySingleWRRAndNC on HW and test Passed in ~9 min (down from ~19.5 min)