Skip to content

[Celestica] Ladakh800bcls: (Resubmit) Decouple RTM from MDIO, Add RTM CTRL Config Function, and Add RTM config into platform_manager#1365

Open
ezongCLS wants to merge 3 commits into
facebook:mainfrom
ezongCLS:resubmit-pr1260
Open

[Celestica] Ladakh800bcls: (Resubmit) Decouple RTM from MDIO, Add RTM CTRL Config Function, and Add RTM config into platform_manager#1365
ezongCLS wants to merge 3 commits into
facebook:mainfrom
ezongCLS:resubmit-pr1260

Conversation

@ezongCLS

@ezongCLS ezongCLS commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run
clang-format.............................................................Passed
shellcheck...........................................(no files to check)Skipped
shfmt................................................(no files to check)Skipped
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check json...........................................(no files to check)Skipped
check for merge conflicts................................................Passed
ruff check...........................................(no files to check)Skipped
ruff format..........................................(no files to check)Skipped
Prevent sai_impl in fboss manifest.......................................Passed

Summary

This is a re-submit of PR1260

  • Based on the modification of BSP MDIO driver, remove the unused iobuf from the MDIO device initialisation in platform_manager.json.
  • Add the functions to support the logic of RTM CTRL creation.
  • Add the RTM CTRL conifg into platform_manager.json.
  • Update the corresponding sysfs of PhyResetPath in Ladakh800bcls_PhyBspMapping.csv.

Motivation

A recent PR in fboss.bsp.kmods has modified the creation of MDIO controller and added exclusive driver for retimer controller IP block. This PR is to modify the fboss platform_manager logic for the two device to match the latest driver.

Test Plan

Tested on Anacapa 25% (Ladakh800b):

  • platform_manager creating the RTM CTRL devices:
I1012 02:35:48.961768 436503 PciExplorer.cpp:456] Successfully created device RTM_L_RTM_CTRL_PORT_1 at /sys/bus/pci/devices/0000:17:00.0/fboss_iob_pci.rtm_ctrl.1080 using /dev/fbiob_1d9b.0011.10ee.0007. Args - deviceName: rtm_ctrl instanceId: 1080, csrOffset: 0x480c0, iobufOffset: 0x0
I1012 02:35:48.961794 436503 DataStore.cpp:78] Updating SysfsPath for /[RTM_L_RTM_CTRL_PORT_1] to /sys/bus/pci/devices/0000:17:00.0/fboss_iob_pci.rtm_ctrl.1080
I1012 02:35:48.961800 436503 PciExplorer.cpp:370] Creating device RTM_L_RTM_CTRL_PORT_2 in /sys/bus/pci/devices/0000:17:00.0 using /dev/fbiob_1d9b.0011.10ee.0007. Args - deviceName: rtm_ctrl instanceId: 1081, csrOffset: 0x480c4, iobufOffset: 0x0
  • rtm_ctrl devices in /run/devmap/rtms:
[root@localhost ~]# tree /run/devmap/rtms/
/run/devmap/rtms/
├── rtm_ctrl_mdio_l_10_1 -> /sys/bus/pci/devices/0000:17:00.0/fboss_iob_pci.rtm_ctrl.1089
├── rtm_ctrl_mdio_l_1_1 -> /sys/bus/pci/devices/0000:17:00.0/fboss_iob_pci.rtm_ctrl.1080
...
  • mdio-busses after modification (removed reset_rtm):
[root@localhost ~]# ls /run/devmap/mdio-busses/mdio_bus_ctrl_l_1/reset_rtm*
ls: cannot access '/run/devmap/mdio-busses/mdio_bus_ctrl_l_1/reset_rtm*': No such file or directory

@ezongCLS
ezongCLS requested review from a team as code owners July 7, 2026 07:40
@meta-cla meta-cla Bot added the CLA Signed label Jul 7, 2026
@meta-codesync

meta-codesync Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@mikechoifb has imported this pull request. If you are a Meta employee, you can view this in D111283775.

@facebook-github-tools

Copy link
Copy Markdown

@ezongCLS has updated the pull request. You must reimport the pull request before landing.

@facebook-github-tools

Copy link
Copy Markdown

@ezongCLS has updated the pull request. You must reimport the pull request before landing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant