[Celestica] Ladakh800bcls: (Resubmit) Decouple RTM from MDIO, Add RTM CTRL Config Function, and Add RTM config into platform_manager#1365
Open
ezongCLS wants to merge 3 commits into
Conversation
…e them explicitly with in platform manager
Contributor
|
@mikechoifb has imported this pull request. If you are a Meta employee, you can view this in D111283775. |
|
@ezongCLS has updated the pull request. You must reimport the pull request before landing. |
|
@ezongCLS has updated the pull request. You must reimport the pull request before landing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
This is a re-submit of PR1260
iobuffrom the MDIO device initialisation inplatform_manager.json.platform_manager.json.sysfsofPhyResetPathinLadakh800bcls_PhyBspMapping.csv.Motivation
A recent PR in
fboss.bsp.kmodshas modified the creation of MDIO controller and added exclusive driver for retimer controller IP block. This PR is to modify the fbossplatform_managerlogic for the two device to match the latest driver.Test Plan
Tested on Anacapa 25% (Ladakh800b):
platform_managercreating the RTM CTRL devices:rtm_ctrldevices in/run/devmap/rtms:mdio-bussesafter modification (removedreset_rtm):platform_manager_dvt.txt
platform_manager_evt.txt