Set platform in REAPI Action message#1366
Open
sf229 wants to merge 1 commit into
Open
Conversation
REAPI v2.2 introduced the platform field in the Action message as the preferred location for platform properties over the previously used Command message. The platform field in the Command message was marked as deprecated in REAPI v2.8, but both fields should still be set. See: remote_execution/oss/re_grpc_proto/proto/build/bazel/remote/execution/v2/remote_execution.proto:653-660
meta-cla
Bot
added
the
CLA Signed
Author
|
Buildbarn recently removed support for reading the platform properties from the Command message, making it incompatible with buck2. |
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D110949978. (Because this pull request was imported automatically, there will not be any future comments.) |
Contributor
|
This is exactly the right thing to do, @ meta please merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REAPI v2.2 introduced the platform field in the Action message as the preferred location for platform properties over the previously used Command message.
The platform field in the Command message was marked as deprecated in REAPI v2.8, but both fields should still be set.
See: remote_execution/oss/re_grpc_proto/proto/build/bazel/remote/execution/v2/remote_execution.proto:653-660