superconsole: styling tweaks and (hopefully?) improvements#1357
Open
davidbarsky wants to merge 6 commits into
Open
superconsole: styling tweaks and (hopefully?) improvements#1357davidbarsky wants to merge 6 commits into
davidbarsky wants to merge 6 commits into
Conversation
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D110625146. (Because this pull request was imported automatically, there will not be any future comments.) |
0e482a9 to
788738c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi folks! I recently starting using Buck2 again (I didn't realize how much I missed it until I developed a moderately complicated build!). Anyways, I had some spare cycles and polished the superconsole TUI to be more consistent and bring out the latent tabular design. Screenshot of this in Ghostty below:
Here are the concrete changes:
─, U+2500) instead of the hyphen.ConsoleInteraction(consisting of toggle, key, resize), which is now used to immediately redraw the superconsole.EventDisplay { label, detail, category }instead of a pre-flatted string like 1"{label} -- {detail}". The rough before/after is below. Here are some notable changes:·separator.pkg:foo [copy foo]would now render aspkg:foo [copy].Before:
After:
I don't recall how importing a PR into a phrabricator diff works, but these commits all should build independently.