github: don't run build-and-test twice for branches with pull requests#1355
Open
daandemeyer wants to merge 1 commit into
Open
github: don't run build-and-test twice for branches with pull requests#1355daandemeyer wants to merge 1 commit into
daandemeyer wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D110602235. (Because this pull request was imported automatically, there will not be any future comments.) |
The workflow triggers on both push and pull_request without a branch filter, so pushing to a branch that has an open pull request runs every job twice: once for the push event and once for the pull_request event. Restrict the push trigger to the main branch. Pull requests still run via the pull_request event and main still runs post-merge CI; branches without a pull request can be run manually via workflow_dispatch.
daandemeyer
force-pushed
the
push-otomxnkntuko
branch
from
64f2448 to
3777f95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow triggers on both push and pull_request without a branch filter, so pushing to a branch that has an open pull request runs every job twice: once for the push event and once for the pull_request event.
Restrict the push trigger to the main branch. Pull requests still run via the pull_request event and main still runs post-merge CI; branches without a pull request can be run manually via workflow_dispatch.