feat(net): display proxy ip on Net widget#3170
Open
mattan8844 wants to merge 5 commits intoexelban:masterfrom
Open
feat(net): display proxy ip on Net widget#3170mattan8844 wants to merge 5 commits intoexelban:masterfrom
mattan8844 wants to merge 5 commits intoexelban:masterfrom
Conversation
- add a manual "Refresh" action for public IP in Net settings - keep public IP related settings rows in sync with the Public IP toggle - detect scoped/global HTTP, HTTPS, and SOCKS proxy settings - fetch and store the external IP seen through the configured proxy - show a new "Proxy IP" row in the Net popup Address section - refresh direct and proxied public IP values together
This reverts commit 6625b19.
This reverts commit cb2ad49.
|
In the implementation, it will be more convenient to see if a proxy is connected and what IP it has, and to see what IP it has without a proxy - it is more convenient to implement this as a 2-in-1 |
Signed-off-by: mattan8844 <mattan8844@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a global HTTP/HTTPS proxy is configured on the system, the proxy IP will be displayed in the address section.
For users who frequently connect to a proxy and switch proxies from time to time, displaying the proxy IP in the widget makes it easier for them to see which proxy they are currently connected to.
***For users who do not use a proxy, this feature does not change the current experience. If no global proxy is configured, the row of "proxy IP" will not be shown in the widget.