Skip to content

fix: improve RAM usage calculation and top processes #3160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agentHits wants to merge 2 commits into
base: master
Choose a base branch
from
+66 −15
Open

fix: improve RAM usage calculation and top processes #3160

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69ca9be
fix: improve RAM usage calculation and top processes
agentHits Apr 21, 2026
b405842
(fix) Scope RAM usage
agentHits Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Modules/RAM/main.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ public class RAM: Module {

self.settingsView.callback = { [weak self] in
self?.usageReader?.read()
self?.processReader?.read()
Copy link
Copy Markdown
Owner

@exelban exelban Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why open settings trigger process read?

Copy link
Copy Markdown
Author

@agentHits agentHits Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intent there was to refresh the top process list immediately after toggling RAM-related settings, especially the combined processes option.

You're right though: settingsView.callback is too broad for that and can also be triggered when opening/settings refresh. I'll remove the process read from this callback and keep it scoped only to the setting that actually affects the process list.

}
self.settingsView.setInterval = { [weak self] value in
self?.processReader?.read()
Expand Down
Loading