Skip to content

chore: pin gh actions versions to latest sha #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oysandvik94 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: pin gh actions versions to latest sha #11

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db4cd23
chore: pin gh actions versions to latest sha
oysandvik94 Jun 18, 2025
99ac38d
chore: add comment describing version, and use commit of latest release
oysandvik94 Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,14 @@ runs:
steps:
- name: Setup java
if: ${{ inputs.cache }}
uses: actions/setup-java@v4.5.0
uses: actions/setup-java@f4f1212c880fdec8162ea9a6493f4495191887b4
with:
distribution: ${{ inputs.distribution }}
overwrite-settings: ${{ inputs.overwrite-settings }}
java-version: ${{ inputs.java-version }}
cache: ${{ inputs.cache == 'true' && 'maven' || '' }}

- name: Set up Maven
uses: stCarolas/setup-maven@v5
uses: stCarolas/setup-maven@d6af6abeda15e98926a57b5aa970a96bb37f97d1

@vladimirr9 vladimirr9 Jun 18, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think common practice is to put the version that's being pinned as a comment in the same line so that people know which version the hash is referring to. Could you do that here and for the action above it?

@oysandvik94 oysandvik94 Jun 18, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Also realized I should use release version, not latest commit

with:
maven-version: ${{ inputs.maven-version }}