-
Notifications
You must be signed in to change notification settings - Fork 838
feat: add reference-free FluencyLLMEval and CoherenceLLMEval descriptors #1834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mostaphaelansari
wants to merge
3
commits into
evidentlyai:main
Choose a base branch
from
mostaphaelansari:feat/reference-free-quality-metrics-1801
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| ============================= test session starts ============================= | ||
| platform win32 -- Python 3.11.14, pytest-7.4.4, pluggy-1.6.0 -- C:\Users\mosta\anaconda3\envs\evidently\python.exe | ||
| cachedir: .pytest_cache | ||
| rootdir: C:\Users\mosta\Documents\GitHub\evidently | ||
| configfile: pyproject.toml | ||
| plugins: anyio-4.12.1, Faker-40.4.0, asyncio-0.23.7, mock-3.14.0 | ||
| asyncio: mode=Mode.STRICT | ||
| collecting ... collected 10 items | ||
|
|
||
| tests/features/test_llm_judge.py::test_parse_response[template0-results0] PASSED [ 10%] | ||
| tests/features/test_llm_judge.py::test_parse_response[template1-results1] PASSED [ 20%] | ||
| tests/features/test_llm_judge.py::test_parse_response[template2-results2] PASSED [ 30%] | ||
| tests/features/test_llm_judge.py::test_parse_response[template3-results3] PASSED [ 40%] | ||
| tests/features/test_llm_judge.py::test_llm_judge PASSED [ 50%] | ||
| tests/features/test_llm_judge.py::test_multicol_llm_judge PASSED [ 60%] | ||
| tests/features/test_llm_judge.py::test_run_snapshot_with_llm_judge PASSED [ 70%] | ||
| tests/features/test_llm_judge.py::test_fluency_llm_eval PASSED [ 80%] | ||
| tests/features/test_llm_judge.py::test_coherence_llm_eval PASSED [ 90%] | ||
| tests/features/test_llm_judge.py::test_reference_free_evals_importable PASSED [100%] | ||
|
|
||
| ============================== warnings summary =============================== | ||
| src\evidently\legacy\tests\utils.py:183 | ||
| src\evidently\legacy\tests\utils.py:183 | ||
| C:\Users\mosta\Documents\GitHub\evidently\src\evidently\legacy\tests\utils.py:183: DeprecationWarning: numpy.core is deprecated and has been renamed to numpy._core. The numpy._core namespace contains private NumPy internals and its use is discouraged, as NumPy internals can change without warning in any release. In practice, most real-world usage of numpy.core is to access functionality in the public NumPy API. If that is the case, use the public NumPy API. If not, you are using NumPy internals. If you would still like to access an internal attribute, use numpy._core.numeric. | ||
| np.core.numeric.ScalarType = np.core.numeric.ScalarType + (ApproxValue, ApproxValueNoDict) # type: ignore[attr-defined] | ||
|
|
||
| tests\conftest.py:12 | ||
| tests\conftest.py:12 | ||
| C:\Users\mosta\Documents\GitHub\evidently\tests\conftest.py:12: DeprecationWarning: numpy.core is deprecated and has been renamed to numpy._core. The numpy._core namespace contains private NumPy internals and its use is discouraged, as NumPy internals can change without warning in any release. In practice, most real-world usage of numpy.core is to access functionality in the public NumPy API. If that is the case, use the public NumPy API. If not, you are using NumPy internals. If you would still like to access an internal attribute, use numpy._core.numeric. | ||
| np.core.numeric.ScalarType = np.core.numeric.ScalarType + (ApproxValue,) # type: ignore[attr-defined] | ||
|
|
||
| tests/features/test_llm_judge.py::test_llm_judge | ||
| tests\features\test_llm_judge.py:103: PytestWarning: The test <Function test_llm_judge> is marked with '@pytest.mark.asyncio' but it is not an async function. Please remove the asyncio mark. If the test is not marked explicitly, check for global marks applied via 'pytestmark'. | ||
| @pytest.mark.asyncio | ||
|
|
||
| tests/features/test_llm_judge.py::test_multicol_llm_judge | ||
| tests\features\test_llm_judge.py:119: PytestWarning: The test <Function test_multicol_llm_judge> is marked with '@pytest.mark.asyncio' but it is not an async function. Please remove the asyncio mark. If the test is not marked explicitly, check for global marks applied via 'pytestmark'. | ||
| @pytest.mark.asyncio | ||
|
|
||
| -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html | ||
| ======================= 10 passed, 6 warnings in 0.09s ======================== | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this file from PR, as it is not needed in the repository.
We will see successful tests after workflow launch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback! I’ve removed the file from the PR as requested. Let me know if anything else needs adjustment.