Improve WKT performance by writing coordinates directly - #58
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Improves WKT serialization performance by avoiding generic float printing and writing floating-point coordinates directly into an IOBuffer, and tightens the allocation regression test to reflect the intended improvement.
Changes:
- Add a specialized
write_coordinatefast path usingBase.Ryu.writeshortestforIOBuffer+Float*coordinates. - Route point-coordinate serialization through
write_coordinateinstead ofprint. - Lower the WKT allocation ceiling in tests to enforce the performance improvement.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/wkt.jl |
Introduces a fast-path for writing float coordinates directly into an IOBuffer during WKT generation. |
test/runtests.jl |
Tightens the allocation threshold for getwkt to validate the reduced-allocation behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+57
to
+64
| function write_coordinate(io::IOBuffer, value::Union{Float16,Float32,Float64}) | ||
| Base.ensureroom(io, 24) | ||
| io.ptr = Base.Ryu.writeshortest(io.data, io.ptr, value) | ||
| io.size = max(io.size, io.ptr - 1) | ||
| return nothing | ||
| end | ||
|
|
||
| write_coordinate(io::IO, value) = print(io, value) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@asinghvi17 This makes it faster then ArchGDAL again, at the cost of use internal Base methods.