Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @naltatis - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
daniel309
reviewed
Jun 6, 2025
daniel309
approved these changes
Jun 6, 2025
Contributor
daniel309
left a comment
daniel309
left a comment
There was a problem hiding this comment.
lgtm (for luxtronik.yaml)
premultiply
approved these changes
Jun 6, 2025
Member
premultiply
left a comment
premultiply
left a comment
There was a problem hiding this comment.
Keine Einwände :) LGTM
Ich glaub die ganzen veralteten Wallbe-Templates aus den frühen Anfangstagen können wir auch demnächst mal löschen.
Das sollte heute alles intern mit der aktuellen Phoenix-Implementierung abgehandelt sein.
andig
pushed a commit
that referenced
this pull request
Aug 11, 2025
StarF666
pushed a commit
to StarF666/evcc
that referenced
this pull request
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to #21670
Cleaning up product brands and descriptions.
@daniel309 can you double check my Luxtronic modifications. I had some trouble finding the right devices from the manufacturers websites (e.g. Aeroplus). I added some infos from the description of your Luxtronic PR. If you have more infos no the devices just comment them here.