Conversation
Changes the standard JobU attribute registry to add retry multiplier and jitter policy values while preserving compatibility with Phase 3 snapshots.
There was a problem hiding this comment.
Pull request overview
This PR updates JobU’s standard attribute registry to introduce Phase 4 retry tuning attributes (retry.jitter and retry.multiplier) and adds/updates tests to ensure older Phase 3 persisted snapshots decode with sensible Phase 4 defaults while keeping partial documents partial.
Changes:
- Extend
StandardAttributeRegistrywith two new numeric retry attributes, including defaults and validation rules. - Add/adjust persistence and repository tests to confirm Phase 3-era stored documents missing the new fields are upgraded on materialized decode.
- Add public JSON round-trip coverage for the new retry number attributes.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/jobu-run-attempt-repository-test.cpp | Adds a repository-level regression test ensuring legacy run snapshots load with Phase 4 retry defaults applied. |
| test/domain-storage-test.cpp | Updates attribute document tests to verify Phase 3 materialized documents are upgraded while partial documents remain partial. |
| test/attribute-materialization-test.cpp | Expands standard attribute definition/validation tests and adds JSON round-trip coverage for retry.jitter and retry.multiplier. |
| src/jobu/attribute_registry.hpp | Updates documentation wording and increases the fixed definition array size to include new attributes. |
| src/jobu/attribute_registry.cpp | Adds the new attribute definitions, defaults, and validation logic for the new numeric fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the standard JobU attribute registry to add retry multiplier and jitter policy values while preserving compatibility with Phase 3 snapshots.