fix(output/http): bound http.Transport connection pool to fix v1.12.0 OOM#837
Open
samcm wants to merge 1 commit into
Open
fix(output/http): bound http.Transport connection pool to fix v1.12.0 OOM#837samcm wants to merge 1 commit into
samcm wants to merge 1 commit into
Conversation
… OOM PR #835 wrapped the HTTP output sink's transport with otelhttp.NewTransport on top of an unconfigured http.DefaultTransport clone (MaxIdleConnsPerHost=2). With BatchItemProcessor running thousands of workers all POSTing to the same upstream, exports stacked up in awaitWantConn, BatchItemProcessor queues backfilled, and pods OOMKilled after ~13 min. Size MaxConnsPerHost, MaxIdleConnsPerHost and MaxIdleConns to config.Workers so the pool tracks concurrent demand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #835 wrapped the HTTP output sink's transport with
otelhttp.NewTransporton top of an unconfiguredhttp.DefaultTransportclone, whoseMaxIdleConnsPerHost=2left the pool starved under load. WithBatchItemProcessorrunning thousands of workers all POSTing to the same upstream, exports stacked up inawaitWantConn(live pprof showed 362 goroutines blocked there, 27,931 total, 30+ GB resident)This sizes
MaxConnsPerHost,MaxIdleConnsPerHostandMaxIdleConnstoconfig.Workersso the pool tracks concurrent export demand instead of throttling against the stdlib default.