consumoor: add disabledTables config to skip output tables#824
Open
samcm wants to merge 2 commits into
Open
Conversation
Routes whose target table appears in disabledTables are not registered with the router or the writer. Events whose every route targets a disabled table are dropped (StatusDelivered) instead of NAK'd so Kafka offsets advance. Unknown table names fail validation at startup. The same drop-vs-NAK fix applies to disabledEvents — previously disabling an event that wasn't intentionally unsupported caused infinite Kafka redelivery.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
disabledTablesto the consumoor config so an output table can be turned off without code changes (e.g.libp2p_peer). Routes targeting a disabled table are skipped in both the router and writer; events whose every route lands in a disabled table are dropped (StatusDelivered) so Kafka offsets advance instead of redelivering forever. The same drop-vs-NAK fix applies todisabledEvents, which previously caused infinite redelivery when used on events outside theintentionallyUnsupportedEventsset.