fix: survive incomplete semver installs at startup (EPICSHOP-HD) - #649
Merged
Merged
Conversation
Learner installs can ship a broken nested semver package that fatally crashes startup on the static import. Load it dynamically, skip the engines check if resolution fails, and publish the helper with start.js. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
|
View your CI Pipeline Execution ↗ for commit f0b6861
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
kody-bot
marked this pull request as ready for review
August 4, 2026 00:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sentry EPICSHOP-HD reported a fatal uncaught exception on learner machines:
Cannot find module './functions/prerelease'from a nested@epic-web/workshop-app/node_modules/semverinstall.start.jspreviously did a staticimport semver from 'semver'for the Node engines check, so a corrupt/incompletesemverpackage took down the whole process before the server could boot.Changes
semverdynamically and skip the engines check (with a warning) when resolution failsnode-version-check.jsand publish it alongsidestart.jsstart.jsrelative importsStatus
23e61388b9100eb0b3a17de9bf86df6f53f6549dInvalid URLonGET *splat) left alone (unrelated)