Skip to content

Fix canonical workshop typecheck setup - #647

Merged
kody-bot merged 1 commit into
mainfrom
cursor/epicshop-canonical-typecheck-6562
Jul 29, 2026
Merged

Fix canonical workshop typecheck setup#647
kody-bot merged 1 commit into
mainfrom
cursor/epicshop-canonical-typecheck-6562

Conversation

@kentcdodds

@kentcdodds kentcdodds commented Jul 29, 2026

Copy link
Copy Markdown
Member

Summary

  • generate optional workshop app artifacts before root TypeScript validation
  • skip typecheck only when a workshop has no typecheck script
  • protect command ordering and failure semantics with a regression test

Context

Follow-up to #645 for failures in react-and-the-vanishing-network and react-e2e-testing-with-playwright.

Validation

  • pre-commit validation passed (format, lint, typecheck, build)
  • pre-push tests passed (36 files, 279 tests)
  • canonical workflow assertions passed
  • live epicshop add of react-e2e-testing-with-playwright followed by generation removed the reported missing route types and Prisma exports; the existing typecheck still returned nonzero for unrelated genuine project errors, confirming failures are not masked
Open in Web Open in Cursor 

@nx-cloud

nx-cloud Bot commented Jul 29, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 47bf23b

Command Status Duration Result
nx run-many --target typecheck ✅ Succeeded 2s View ↗
nx run-many --target build ✅ Succeeded <1s View ↗
nx lint ✅ Succeeded 3s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-07-29 03:01:34 UTC

@kody-bot
kody-bot marked this pull request as ready for review July 29, 2026 02:57
@kody-bot
kody-bot merged commit 07110b5 into main Jul 29, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants