fix: run workshop epicshop add retry loop with bash on Windows - #644
Merged
Conversation
Windows runners default to PowerShell, which rejected the bash while-loop and failed Setup on every workshop. Force shell: bash and disable matrix fail-fast so one OS does not cancel the others.
kody-bot
marked this pull request as ready for review
July 29, 2026 00:54
|
View your CI Pipeline Execution ↗ for commit 98b9ccd
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #643. Workshop Setup still failed on Windows because the new
epicshop addretry loop is bash, and Windows runners default to PowerShell (Missing opening '(' after keyword 'while'). That failed the Windows matrix leg, and defaultfail-fastcancelled ubuntu/macos even though Test + Deploy were already green.Changes
shell: bashon the Add repo stepstrategy.fail-fast: falseso one OS failure does not cancel the othersTest plan