Skip to content

[PLA-2420] Fix release CI - #37

Merged
Bradez merged 12 commits into
3.xfrom
bugfix/PLA-2420/fix-release-ci
Jun 16, 2026
Merged

[PLA-2420] Fix release CI#37
Bradez merged 12 commits into
3.xfrom
bugfix/PLA-2420/fix-release-ci

Conversation

@JayPavlina

@JayPavlina JayPavlina commented May 28, 2026

Copy link
Copy Markdown
Collaborator

Additional Info

This pull request makes several important improvements to the build and release automation and enhances the usability of the PlatformClient class. The main changes include consolidating and expanding CI workflows, improving the release process for both NuGet and Unity packages, and making the PlatformClient easier to use with sensible defaults.

CI/CD and Release Workflow Improvements:

  • The .github/workflows/build.yml workflow was significantly enhanced to handle both NuGet and Unity Package Manager (UPM) releases, including support for manual workflow dispatches and improved artifact publishing. The workflow now uploads NuGet packages and UPM tarballs to draft releases, publishes to NuGet.org using OIDC authentication, and pushes Unity packages to a dedicated repository. A new job ensures releases are only published after all assets are attached. ([[1]](https://github.com/enjin/platform-csharp-sdk/pull/37/files#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721L8-R24), [[2]](https://github.com/enjin/platform-csharp-sdk/pull/37/files#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721L55-R232))
  • The now-redundant .github/workflows/unity.yml workflow was deleted, consolidating all packaging and release logic into the improved build workflow. ([.github/workflows/unity.ymlL1-L104](https://github.com/enjin/platform-csharp-sdk/pull/37/files#diff-3b739592ec0b95d14f953ef27c16fa130d2a7aa4cdb5b410c64357ac161d926cL1-L104))

PlatformClient Usability Enhancements:

  • The PlatformClient class now provides a DefaultBaseAddress (pointing to the Enjin Platform GraphQL endpoint) and allows the baseAddress parameter to be omitted or set to null, in which case the default is used. ([[1]](https://github.com/enjin/platform-csharp-sdk/pull/37/files#diff-8c215af18b2a74aa2e062a881e7f06467aee7a5217469101ff44a81ae5759d20R18-R22), [[2]](https://github.com/enjin/platform-csharp-sdk/pull/37/files#diff-8c215af18b2a74aa2e062a881e7f06467aee7a5217469101ff44a81ae5759d20L61-R77))
  • The default User-Agent string was updated to a more descriptive value: Enjin-Platform-CSharp-SDK/{version}. ([src/Enjin.Platform.Sdk/Enjin.Platform.Sdk/Platform/PlatformClient.csL41-R46](https://github.com/enjin/platform-csharp-sdk/pull/37/files#diff-8c215af18b2a74aa2e062a881e7f06467aee7a5217469101ff44a81ae5759d20L41-R46))
  • Additional unit tests were added to verify that the default and null baseAddress behaviors work as intended. ([src/Enjin.Platform.Sdk/Enjin.Platform.Sdk.Tests/Unit/Platform/PlatformClientSmokeTest.csL214-R241](https://github.com/enjin/platform-csharp-sdk/pull/37/files#diff-a1b48eea8d79912c8cd3e0cb2309a0b848c9fec428f5300b7587639bbc6301a8L214-R241))

@JayPavlina

JayPavlina commented May 28, 2026

Copy link
Copy Markdown
Collaborator Author

Needs a few things before merge:

  • Add the NUGET_API_KEY secret in repo Settings → Secrets and variables → Actions. Use an API key from nuget.org scoped to the Enjin.Platform.Sdk package.
  • UNITY_SDK_DEPLOY_KEY ssh key needs to be set up
  • v3.0.0 release and tag should be deleted
  • should do a dry run of the workflow on this branch (of parts that can be tested) after those things are done

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Comment thread .github/workflows/build.yml
Comment thread .github/workflows/build.yml Outdated
@JayPavlina
JayPavlina marked this pull request as ready for review June 16, 2026 16:29
@JayPavlina
JayPavlina requested a review from Copilot June 16, 2026 16:29

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Comment thread .github/workflows/build.yml Outdated
Comment thread .github/workflows/build.yml
@JayPavlina
JayPavlina requested a review from Bradez June 16, 2026 16:36
@Bradez
Bradez merged commit 26a235a into 3.x Jun 16, 2026
3 checks passed
@Bradez
Bradez deleted the bugfix/PLA-2420/fix-release-ci branch June 16, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants