-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Add wasm-bindgen support #23493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add wasm-bindgen support #23493
Changes from 4 commits
e9bf8a0
135405f
e5b67a7
6732eec
1708fdf
5f3feae
8ff4580
44d0f55
836fbe6
2debab9
ea4eab0
d7faa6b
cb281cb
2843e36
26cd774
cfc9b11
c2dfc91
4196290
8c08d8e
50e8795
09992ae
126f551
c779002
8e5fd0a
feaf9be
50b600f
50c4fe1
24be666
fe3db01
6d1c5ff
9c92122
3be75f2
4e8aab6
20839d5
95c89b5
65fca2a
e40e789
45c8c8f
11855f5
24d681b
2ef1305
dfd65cf
fe99e55
1c74e70
79a4af7
9627ee3
cba2609
d56b37f
64f0dad
e146085
44d3059
1b72851
afebddc
80d0b67
3cd3b31
68eb9b2
2b1c672
d229aaf
e55a8a1
bc3a3f0
bf9d095
6029dd7
c082ea1
78b0a55
1925b05
b009b61
2b591ee
4b27565
a739374
5cc0091
094743a
ebd53fe
076abcb
dc705f4
06cf81a
f19ae01
b804a48
298d746
7898c9d
389f901
aa7bcc2
3f38afd
2ae5656
067c6c8
4661535
13b5ce7
aa92019
d96723a
e9488b9
311eba5
a8aac50
c279e12
6c64bc7
d93502c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,6 +36,7 @@ | |
| CACHE = None | ||
| PORTS = None | ||
| COMPILER_WRAPPER = None | ||
| WASM_BINDGEN = None | ||
|
|
||
| # Set by init() | ||
| EM_CONFIG = None | ||
|
|
@@ -58,6 +59,7 @@ def fix_js_engine(old, new): | |
| def normalize_config_settings(): | ||
| global CACHE, PORTS, LLVM_ADD_VERSION, CLANG_ADD_VERSION, CLOSURE_COMPILER | ||
| global NODE_JS, NODE_JS_TEST, V8_ENGINE, JS_ENGINES, SPIDERMONKEY_ENGINE, WASM_ENGINES | ||
| global WASM_BINDGEN | ||
|
|
||
| # EM_CONFIG stuff | ||
| if not JS_ENGINES: | ||
|
|
@@ -75,6 +77,7 @@ def normalize_config_settings(): | |
| JS_ENGINES = [listify(engine) for engine in JS_ENGINES] | ||
| WASM_ENGINES = [listify(engine) for engine in WASM_ENGINES] | ||
| CLOSURE_COMPILER = listify(CLOSURE_COMPILER) | ||
| WASM_BINDGEN = listify(WASM_BINDGEN) | ||
| if not CACHE: | ||
| CACHE = path_from_root('cache') | ||
| if not PORTS: | ||
|
|
@@ -124,6 +127,7 @@ def parse_config_file(): | |
| 'CACHE', | ||
| 'PORTS', | ||
| 'COMPILER_WRAPPER', | ||
| 'WASM_BINDGEN', | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could we avoid the new config setting completely and just rely on wasm-bindgen being in the PATH when a user added This is what we do for
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
| ) | ||
|
|
||
| # Only propagate certain settings from the config file. | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.