Skip to content

Fix ignored fields system test query#3571

Open
mturac wants to merge 1 commit into
elastic:mainfrom
mturac:fix/issue-3524
Open

Fix ignored fields system test query#3571
mturac wants to merge 1 commit into
elastic:mainfrom
mturac:fix/issue-3524

Conversation

@mturac

@mturac mturac commented May 15, 2026

Copy link
Copy Markdown

Closes #3524

What changed

  • Read the _ignored metadata field from doc values in the runtime field script used by system tests.
  • Add a regression test that locks the query to doc-values lookup and prevents the stored-fields lookup from coming back.

Tests

  • go test ./internal/testrunner/runners/system
  • make format
  • git diff --check

@jsoriano

Copy link
Copy Markdown
Member

/test

@jsoriano

Copy link
Copy Markdown
Member

test integrations

@jsoriano jsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM, let's wait to tests.

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown

Created or updated PR in integrations repository to test this version. Check elastic/integrations#19022

@elasticmachine

elasticmachine commented May 15, 2026

Copy link
Copy Markdown
Contributor

@jsoriano

Copy link
Copy Markdown
Member

This change produces failures in many packages, see elastic/integrations#19022

They may be legit, but we need to think on an strategy to enable this in a controlled way, so we don't need to review and fix all packages at once.

@mturac

mturac commented May 15, 2026

Copy link
Copy Markdown
Author

Thanks for checking this. That makes sense, I had only scoped the change to the query behavior, but the package-level fallout means the rollout needs to be narrower.

I’ll rework this so the stricter ignored-fields check can be enabled in a controlled way instead of forcing all affected packages to be fixed in one pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

validateIgnoredFields silently passes: runtime script never reads _ignored

3 participants