Close the rally report file after parsing

[buley]

Summary

Close the CSV report file after parsing the Rally output instead of returning with the descriptor still open. This factors the parsing path through a small helper so the close happens on every path and adds unit coverage for both the happy path and close failures.

Testing

• go test ./internal/benchrunner/runners/rally

[cla-checker-service]

💚 CLA has been signed

[buley]

I have signed the CLA 👍🏻

[jsoriano]

Hey, thanks for fixing this! Added an small suggestion.

[jsoriano]

The defer should rather be placed in the same method that opens the file. This avoids introducing an unexpected side effect in the function that just parses what is in the reader.

Suggested change

	return parseRallyReport(reportCSV, r.svcInfo.Logs.Folder.Local, errOutput.String())
	defer reportCSV.Close()
	return parseRallyReport(reportCSV, r.svcInfo.Logs.Folder.Local, errOutput.String())

[buley]

Thanks for the suggestion @jsoriano. I moved defer reportCSV.Close() back into runRally immediately after os.Open, so the function that opens the file also owns closing it. parseRallyReport now takes an io.Reader and only parses the CSV, which removes the side effect you called out. I also updated the test to verify parser output rather than close behavior.

[jsoriano]

/test

[elasticmachine]

💔 Build Failed

• Buildkite Build
• Commit: f6a9a08

Failed CI Steps

• :go: Run check-static

History