Add dynamic signal types system test support#3373
Merged
MichelLosier merged 64 commits intoMar 31, 2026
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #3298
Enhances system tests support for otel input packages with dynamic_signal_types with:
signal_typesconfig field to declare what signal types to explicitly expect in the testCallouts
I explored a bit the following ask:
From the Fleet side we don't track what data streams actually get created concretely in ES for a policy, nor do data streams in ES point back to policies in the metadata so it seems to me we are left with constructing expected datastream and index template names in some form. Happy to explore further though if folks feel otherwise.
Additionally, the datastream discovery polls until it first gets a result of matching datastreams
*-dataset-namespace, this though assumes that all expected signals will be produced in the first ingest cycle. In the case forsql_server_input_otelthis works if I omit thesignal_typesoption in the logs system test, although the test fails of course on field assertion, but both metric and log data streams are found. If we think there maybe some variability for the default cause we want to handle here, we can look at a longer wait poll strategy (configurable wait), or goroutine the discovery to poll and enqueue found datastreams as tests run.How to test:
elastic-package test system -vagainst the changes insql_server_input_otelpackage in this PR: Update sql_server_input_otel logs signal test integrations#17794