Skip to content

perf: added teak support - #29

Merged
Asespinel merged 6 commits into
mainfrom
ase/added-teak-support
Jun 23, 2025
Merged

perf: added teak support#29
Asespinel merged 6 commits into
mainfrom
ase/added-teak-support

Conversation

@Asespinel

@Asespinel Asespinel commented Jun 22, 2025

Copy link
Copy Markdown
Contributor

Description

This PR aims to support the Teak release.

Testing instructions

1, Create a Teak environment using Tutor or TVM.
2. Install xblock-imagesgallery using this branch you can follow the official tutor documentation.
3. In a course of study:
Navigate to Settings -> Advanced Settings and go to Advanced Module List settings.
Add: "imagesgallery"
4. Add the component under the "advanced" section
5.
image

@Asespinel
Asespinel requested a review from a team as a code owner June 22, 2025 21:47
@Asespinel Asespinel changed the title Ase/added teak support perf: added teak support Jun 22, 2025

@magajh magajh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Asespinel have we checked that all the gh workflow dependencies are up to date?


We also need to update the CHANGELOG

Comment thread README.rst Outdated
The settings can be changed in ``imagesgallery/settings/common.py`` or, for example, in tutor configurations.

**NOTE**: the current ``common.py`` works with Open edX Palm, Quince, Redwood and Sumac versions.
**NOTE**: the current ``common.py`` works with Open edX Palm, Quince, Redwood,Sumac and Teak versions.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove Palm and Quince from this comment, or we could update it to say something like:

Suggested change
**NOTE**: the current ``common.py`` works with Open edX Palm, Quince, Redwood,Sumac and Teak versions.
**NOTE**: the current ``common.py`` works with Open edX releases >= Palm.

So we don't have to keep adding every new release

Comment thread imagesgallery/__init__.py Outdated
"""

__version__ = "1.0.0"
__version__ = "2.0.0"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a minor bump

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to a minor version

Comment thread CHANGELOG.rst Outdated
Changed
=======

* Updated dependency versions in requirements

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's improve this message before merging

@Asespinel
Asespinel merged commit 45f8ff5 into main Jun 23, 2025
4 checks passed
@Asespinel
Asespinel deleted the ase/added-teak-support branch June 23, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants