Drop the notes about the mixins' metaclass - #169
Open
eda-s-claude-bot[bot] wants to merge 1 commit into
Open
Conversation
They record how the code got here - an attempt with ExtendedType that cannot work - rather than anything a reader of these mixins needs. The rule belongs in the coding guidelines: use a classic mixin when the class it will be combined with is not created by ExtendedType. Co-Authored-By: Patrick Lehmann <Paebbels@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #169 +/- ##
=======================================
Coverage 31.74% 31.74%
=======================================
Files 9 9
Lines 2498 2498
Branches 396 396
=======================================
Hits 793 793
Misses 1705 1705
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation
tests/unit/JUnitDialects/andtests/README.mdcarried a paragraph explaining why theyare not created by
ExtendedType. It records the detour taken while writing them, not anything a reader ofthose mixins needs, and the rule belongs in the coding guidelines rather than in every mixin that follows it.
Related Issues and Pull-Requests
removed. Those notes entered with #163.