Merging keeps the earliest start time - #167
Open
eda-s-claude-bot[bot] wants to merge 1 commit into
Open
Conversation
MergedTestsuiteSummary.Merge() never touched _startTime, so every merged report lost it - the same shape as the hostname before #162. A merged entity started when the earliest of its parts started, and an entity without a start time contributes nothing rather than erasing what is known. The rule lives on the Merged mixin, so the summary and the test suite share it. Found through the command line: 'pyedaa-reports unittest --merge=Ant-JUnit:... --output=CTest-JUnit:...' failed with "The CTest + JUnit format requires a timestamp on <testsuite>, but the report has none", although the same conversion works when the reader hands its document straight to the writer. The merge in between was dropping it. Six conversions were affected: Ant, CTest and GoogleTest into CTest and GoogleTest. Co-Authored-By: Patrick Lehmann <Paebbels@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #167 +/- ##
==========================================
- Coverage 31.74% 31.68% -0.07%
==========================================
Files 9 9
Lines 2498 2506 +8
Branches 396 398 +2
==========================================
+ Hits 793 794 +1
- Misses 1705 1712 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fixes
pyEDAA.Reports.Unittesting:Merging lost the start time.
MergedTestsuiteSummary.Merge()never touched_startTime, so every mergedreport came out without one - the same shape as the hostname before
#162. A merged entity now starts when the earliest of
its parts started, and a part without a start time contributes nothing rather than erasing what is known. The
rule lives on the
Mergedmixin, soMergedTestsuiteandMergedTestsuiteSummaryshare it.Six conversions were affected -
Ant-JUnit4,CTest-JUnitandGoogleTest-JUnitintoCTest-JUnitandGoogleTest-JUnit, whose schemas requiretimestamp:It now exits 0 and writes a schema-valid report.
Unit Tests
tests/unit/Unittesting/Hostname.py: one report, the earliest of two, a report without astart time next to one with, and neither having one.
tests/unit: 157 → 161 passed.Known Issues
children when it never had one, which is what
pyTest-JUnit→CTest-JUnitwould need - is still open andstill yours: pytest writes
timestampon<testsuite>but not on<testsuites>.Related Issues and Pull-Requests
of that matrix fail at application level while passing at unit level.