Volfdb#285
Draft
danovaro wants to merge 9 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #285 +/- ##
===========================================
+ Coverage 71.15% 71.18% +0.03%
===========================================
Files 370 370
Lines 23457 23673 +216
Branches 2463 2492 +29
===========================================
+ Hits 16690 16851 +161
- Misses 6767 6822 +55 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
danovaro
force-pushed
the
feature/FDB-remote-deregister
branch
from
9362fff to
1bb317b
Compare
ChrisspyB
reviewed
Jun 8, 2026
| archive(key, msg.data(), msg.length(), tracingID); | ||
| } | ||
| void FDB::archive(eckit::DataHandle& handle) { | ||
| void FDB::archive(eckit::DataHandle& handle, const std::string& tracingID) { |
Member
There was a problem hiding this comment.
A passing comment: I would use class TracingContext or something similar rather than just a std::string. It seems plausible that this should be something that we might want to be extendable / structured.
danovaro
force-pushed
the
feature/FDB-remote-deregister
branch
2 times, most recently
from
e4d1c46 to
e65b90d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contributor Declaration
By opening this pull request, I affirm the following:
🌈🌦️📖🚧 Documentation FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/fdb/pull-requests/PR-285