feat: refactored mcx in gate_application_functions - #741
Open
invariantfields wants to merge 1 commit into
Open
Conversation
Contributor
|
Hi, sorry. As far as I understand, someone else is working on this issue. You should have seen their comment in the connected issue. Let's not duplicate the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors mcx as suggested in #580
Uses dicts and helper functions to clean up the if else loops.
Related Issues
Closes #580.
Type of Change
Breaking Change?
If yes, describe the impact and migration path:
What was changed?
How was it tested?
Tested for the specific mcx_tests
Checklist
changelog-dev.rstReviewer Notes
I need some suggestions to make sure this is upto the standards for the codebase and will proceed to implement the same refactors to the mcz and mcp as suggested in #580 .