Remove usage of sbp_mult from docstrings - #733
Conversation
7d751c4 to
5320270
Compare
|
Hi @purva-thakre! The changelog check is failing with a 403 error when trying to post the acknowledgment comment. This is a known limitation for PRs from forks, the GITHUB_TOKEN has restricted permissions and can't write comments on the upstream repo. The changelog entry itself is correct and was detected successfully; the failure is purely in the comment-posting step, not in the changelog check. |
5320270 to
3316190
Compare
from the https://github.com/peter-evans/create-or-update-comment page |
|
I have created issue #736 regarding this. |
|
Thanks. Yes, I am aware of the issue with the changelog workflow failing to work with fork PRs #714 (comment) If you have ideas in mind on what a fix could be, feel free to try them out in this PR. |
|
I have made the fix for the workflow issue here, I added a check In the comment tasks so that it would not execute the peter-evans/create-or-update-comment action for forked PR's. Other solutions would be to |
|
Thanks. I will change the workflow such that it does not have to add a comment to the PR. I think this is a better workaround. |
|
Yea that is the best I think 😄 Should I remove the changes I have made to the changelog.yml? |
|
Yes, please undo your change. After that, can you rebase your PR? I added a fix just now in ff426c5 Could you also please remove your entry to changelog-dev to verify the new workflow fails as expected on forked PRs and then add it back to verify it passes? Thanks in advance! |
177eac2 to
4ec1d84
Compare
|
Thank you for helping me debug the new workflow! I will review the changes in your PR by next week. |
|
Hi @purva-thakre, Please do review the changes when you have the time 🤗 |
|
Hi @purva-thakre! Please do take a look at this PR when you have the time |
| :meth:`sbp_mult <qrisp.sbp_mult>` function which heavily profits from more | ||
| workspace. | ||
| We calculate a product of 2 :ref:`QuantumFloats <QuantumFloat>` which heavily | ||
| profits from more workspace. |
There was a problem hiding this comment.
the language needs to be altered. With or without workspace, the depth is the same.
| Squaring a :ref:`QuantumFloat` uses a multiplication algorithm | ||
| which has a high demand of ancilla qubits. |
There was a problem hiding this comment.
same here. I do not think high demand of ancilla qubits is true anymore. Check how q_mult works and then alter the language.
|
|
||
| .. Add new tutorials above this line | ||
|
|
||
|
|


Description
Closes #509
Closes #736
Removes references to the deprecated
sbp_multfunction from docstrings, replacing them with the standard*operator.Related Issues
Closes #509
Closes #736
Type of Change
Breaking Change?
What was changed?
src/qrisp/core/quantum_session.py: Replacedsbp_multimport and call withqf_0 * qf_1in thecompiledocstring example; updated prose and output valuessrc/qrisp/environments/iteration_environment.py: Replaced reference tosbp_multin the precompilation docstring with generic "multiplication algorithm"How was it tested?
The updated docstring values were verified by running the example code with
uv run.Screenshots / Output (if applicable)
New
compiledocstring output:num_qubits(): 45 → 21compile(0).depth(): 497 → 205compile(4).depth(): 258 → 205Checklist
changelog-dev.rstReviewer Notes
N/A