-
Notifications
You must be signed in to change notification settings - Fork 211
Extract CI failure summary into reusable workflow #2625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
8eee923
918fb28
c4d7fe7
7c4932a
ff02192
e482097
666555a
d3deba8
0920c1c
9549d50
9e7a617
894c672
7a2a7ed
3db1a9f
e0b52a8
81e8d43
3dea1d2
7d5efc8
3677234
729e585
43c5779
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,7 @@ | ||
| name: Build macOS | ||
|
|
||
| on: | ||
| push: | ||
| pull_request: | ||
| branches: | ||
| - master | ||
| on: | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| build-macos: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,6 @@ | ||
| name: Build Wheels | ||
|
|
||
| on: | ||
| push: | ||
| pull_request: | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -112,6 +112,21 @@ TEST(core_cpp_core, eCAL_Ok) | |||||
| EXPECT_EQ(false, eCAL::Ok()); | ||||||
| } | ||||||
|
|
||||||
| TEST(core_cpp_core, IntentionalFailure_One) | ||||||
| { | ||||||
| EXPECT_EQ(1, 2) << "Intentional CI failure #1 for summary validation"; | ||||||
| } | ||||||
|
|
||||||
| TEST(core_cpp_core, IntentionalFailure_Two) | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: all parameters should be named in a function [readability-named-parameter]
Suggested change
|
||||||
| { | ||||||
| EXPECT_TRUE(false) << "Intentional CI failure #2 for summary validation"; | ||||||
| } | ||||||
|
|
||||||
| TEST(core_cpp_core, IntentionalFailure_Three) | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: all parameters should be named in a function [readability-named-parameter]
Suggested change
|
||||||
| { | ||||||
| EXPECT_STREQ("expected", "actual") << "Intentional CI failure #3 for summary validation"; | ||||||
| } | ||||||
|
|
||||||
| /* excluded for now, system timer jitter too high */ | ||||||
| #if 0 | ||||||
| namespace | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: all parameters should be named in a function [readability-named-parameter]