Skip to content

Extensions to support shm#125

Open
e-hndrks wants to merge 10 commits into
eclipse-cyclonedds:masterfrom
e-hndrks:extensions-to-support-shm
Open

Extensions to support shm#125
e-hndrks wants to merge 10 commits into
eclipse-cyclonedds:masterfrom
e-hndrks:extensions-to-support-shm

Conversation

@e-hndrks

@e-hndrks e-hndrks commented Jul 6, 2021

Copy link
Copy Markdown
Contributor

No description provided.

sumanth-nirmal and others added 10 commits July 6, 2021 10:08
The initial changes are taken from e-hndrks

  - fixes eclipse-cyclonedds#84

Signed-off-by: Sumanth Nirmal <sumanth.724@gmail.com>
  - Fixes eclipse-cyclonedds#84

Signed-off-by: Sumanth Nirmal <sumanth.724@gmail.com>
  - Set the fixed size mask in flags during the creation of sertype
  - Set the iox_size to sample size during the creation of sertype
  - Fixes eclipse-cyclonedds#84

Signed-off-by: Sumanth Nirmal <sumanth.724@gmail.com>
  - Fixes eclipse-cyclonedds#84

Signed-off-by: Sumanth Nirmal <sumanth.724@gmail.com>
  - fixes eclipse-cyclonedds#84

Signed-off-by: Sumanth Nirmal <sumanth.724@gmail.com>
Signed-off-by: Sumanth Nirmal <sumanth.724@gmail.com>
Signed-off-by: Sumanth Nirmal <sumanth.724@gmail.com>
Signed-off-by: Sumanth Nirmal <sumanth.724@gmail.com>
…lization required

Signed-off-by: Sumanth Nirmal <sumanth.724@gmail.com>
@eboasson

Copy link
Copy Markdown
Contributor

@e-hndrks methinks this unintentionally includes various commits and needs to be rebased.

@reicheratwork reicheratwork left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe have some larger messages in the example program to better illustrate the performance improvements?

{
struct Msg
{
long data;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is enough to just have this small of a message?

Maybe it is better to have a message with a huge payload to better illustrate the performance increase iceoryx can cause?


T& loan_sample();

void return_loan(T& sample);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not overlap with @e-hndrks work on the loan interface?

@e-hndrks

e-hndrks commented Jul 19, 2021

Copy link
Copy Markdown
Contributor Author

Hi @eboasson , the reason why this is not a stand-alone Pull Request is that it builds on top of the changes that have already been made for the loan_sample API, which is therefore a prerequisite for this PR. However, the loan_sample API is currently part of a PR from @sumanth-nirmal, which hasn't been accpeted yet. For that reason, I started from his working branch.
Maybe that was not the smartest approach, but what would be a good alternative?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants