Skip to content

Fix is_http for segmentation model to use token-based detection #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
de-code wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix is_http for segmentation model to use token-based detection #669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sciencebeam_parser/models/segmentation/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ def __init__(
FeatureDef('is_year', lambda f: f.get_str_is_year()),
FeatureDef('is_month', lambda f: f.get_str_is_month()),
FeatureDef('is_email', lambda f: f.get_str_is_email()),
FeatureDef('is_http', lambda f: f.get_str_is_http()),
FeatureDef('is_http', lambda f: f.get_str_is_http_token_based()),
FeatureDef('relative_document_position',
lambda f: f.get_str_relative_document_position()),
FeatureDef('relative_page_position',
Expand Down
16 changes: 16 additions & 0 deletions tests/models/segmentation/data_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,6 +512,22 @@ def test_should_provide_repetitive_pattern_feature(
},
]

def test_should_set_is_http_for_line_starting_with_http_url(
self,
features_provider: SegmentationLineFeaturesProvider
):
layout_document = LayoutDocument(pages=[
LayoutPage(blocks=[
LayoutBlock.for_text('https://doi.org/10.1101/043794'),
LayoutBlock.for_text('regular text line')
])
])
feature_values = [
features.get_str_is_http_token_based()
for features in _iter_line_features(features_provider, layout_document)
]
assert feature_values == ['1', '0']


class TestSegmentationLineFeaturesProviderVectorAround:
def _make_doc_with_block_and_graphics(
Expand Down
Loading