Skip to content

developed controllers for power-heat coupled network and plot it - #653

Open
sf-snigdha wants to merge 6 commits into
e2nIEE:developfrom
sf-snigdha:develop
Open

developed controllers for power-heat coupled network and plot it#653
sf-snigdha wants to merge 6 commits into
e2nIEE:developfrom
sf-snigdha:develop

Conversation

@sf-snigdha

Copy link
Copy Markdown

developed controllers for power-heat coupled network and plot it

Added multinetwork with power and heat networks , developed their simple controller according to the power to gas network and tried to plot the coupled network.
@EPrade

EPrade commented Oct 15, 2024

Copy link
Copy Markdown
Contributor

Hey, cool that your idea resulted in this pull request. It is always a joy to welcome new contributers here!
The code looks good on the first glance. However the files could be sorted into seperate folders to fit the pandapipes structure. Maybe you can restructure the files and the we finalize this PR.

  • the multinet controller would fit into the directory pandapipes/multinet/control
  • the example/tutorial should be changed into a jupyter notebook and would then fit in the tutorial folder
  • the plotting code can be moved to the plotting folder

Please ask if you have any questions.
Looking forward to more great contributions!

@sf-snigdha

Copy link
Copy Markdown
Author

Hi, thank you again for the feedback.

I sincerely apologize for the very late update. It took me much longer than expected to come back to this PR, but I really appreciate your earlier guidance and patience.

I have now updated the PR according to the requested pandapipes structure:

  • moved the multinet controller to src/pandapipes/multinet/control
  • moved the plotting code to src/pandapipes/plotting
  • converted the tutorial example from .py to a Jupyter notebook in the tutorials folder

I also noticed that the previous test failed because the controller import could not be resolved. I have now moved the controller and plotting files into the src package structure, so the notebook import should resolve correctly.

The workflow is currently awaiting maintainer approval.

Could you please check whether the structure is okay now?

Thank you very much!

Comment thread tutorials/coupled_nets_power_heat.py Outdated

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Should I remove this py file and submit again since this file is already moved to multinet/control?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants