docs: note the test suite requires Python 3.7 or higher - #405
Merged
Conversation
The Python test harness uses features added in Python 3.7 (the mock Duo server builds its TLS-version table with ssl.TLSVersion), so make check fails on distributions whose default python3 is older -- for example RHEL/Rocky 8, which ships Python 3.6. Update the README "Running the tests" section to state the 3.7 minimum, clarify that this is a test-only requirement (login_duo and pam_duo have no Python dependency), and note that on such distributions python3 on PATH must resolve to a newer interpreter. Also correct the stale "yum install python" (Python 2 on RHEL) and the bare "python" invocations to python3. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jeffreyparker
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the change
The Python test harness uses
ssl.TLSVersion, added in Python 3.7, to buildthe mock Duo server's TLS-version table. On distributions whose default
python3is older — notably RHEL/Rocky 8, which ships Python 3.6 —mockduo.pyraises
AttributeError: module 'ssl' has no attribute 'TLSVersion'on import,so the mock server never starts and
make checkfails.This is a test-only requirement:
login_duoandpam_duoare C and have noPython dependency (the
min_tlsfeature uses OpenSSL'sSSL_CTX_set_min_proto_version, present on Rocky 8's OpenSSL 1.1.1). Only thetest harness needs the newer interpreter.
Update the README "Running the tests" section to:
test-only.
python3is older than 3.7 (e.g.Rocky 8),
python3onPATHmust resolve to a newer interpreter beforerunning the tests.
yum install python(which installs Python 2 on RHEL) andthe bare
pythoninvocations topython3.Test Plan
Documentation only; no code change.
This PR description was generated with AI assistance (Claude).