pdf: 0.5.1 — fix ref, 0.5.0 was pinned to a commit missing all its features#2224
Merged
Conversation
0.5.0 (duckdb#2218) was pinned to ref 9006e93, which is the batch-1 baseline: it predates every feature the 0.5.0 description advertises. At that commit pdf_images, pdf_split_blank, pdf_watermark, pdf_bates, pdf_redact, and pdf_sign do not exist, so installing 0.5.0 and calling any of them fails with 'function does not exist'. This bumps the ref to d33b1f3 (asubbarao/duckdb-pdf main), where all of those functions are present and tested, plus two robustness fixes landed after the feature merge: - auto-OCR is now best-effort: a blank/scanned page in a plain read no longer hard-errors on machines without a Tesseract model (explicit ocr:=true still raises the actionable install error). - pdf_revisions no longer fatally invalidates the DuckDB connection on a header-less input (an unescaped %PDF- in the error format string escalated a clean IOException to a fatal InternalException). The description already documents these functions; only the pinned ref was wrong. No description changes.
The initial 0.5.1 ref (d33b1f3) still failed the registry's windows_amd64/MSVC leg on two test-portability bugs — pdf_images asserted a forward-slash path that comes back with backslashes under Windows glob expansion, and pdf_split_blank trimmed ' \n\f' but not the '\r' in Windows line endings. Both are fixed upstream (asubbarao/duckdb-pdf#17, test-only), now on main. 177b634 is main HEAD with those fixes; no source/behavior change.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.5.0 (#2218) was pinned to
ref: 9006e93, which is the batch-1 baseline — it predates every feature the 0.5.0 description advertises. At that commitpdf_images,pdf_split_blank,pdf_watermark,pdf_bates,pdf_redact, andpdf_signdon't exist, so a user who installs 0.5.0 and calls any of them getsCatalog Error: function does not exist. My apologies for the bad ref in #2218 — the description was written for the feature surface but the ref pointed at the last commit that had cleared all-platform CI at the time.This bumps the ref to
177b634(duckdb-pdfmain), where all of those functions are present and tested, plus:read_pdfno longer hard-errors on machines without a Tesseract model installed; it degrades to empty text for that page. Explicitocr := truestill raises the actionable install error. (Without this, the extension's own test suite failed on the registry's model-less Linux runner.)pdf_revisionsno longer fatally invalidates the connection on a header-less input — an unescaped%PDF-in the error format string had been escalating a cleanIOExceptioninto a fatalInternalException.' \\n\\f'but not the'\\r'in Windows line endings; both fixed (test-only). This is what an earlier ref (d33b1f3) still tripped on the windows_amd64/MSVC leg.Only the pinned ref changed vs the merged 0.5.0; the description already documents these functions.