-
-
Notifications
You must be signed in to change notification settings - Fork 29
[#2703] Turned '.dockerignore', '.gitignore' and '.gitignore.artifact' into deny lists. #2780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
f3ac199
[#2703] Turned '.dockerignore' and '.gitignore' into deny lists.
AlexSkrypnyk c1954f8
Updated snapshots.
AlexSkrypnyk 08cfabd
[#2703] Excluded tooling dev artifacts from the image build context.
AlexSkrypnyk e9532e9
[#2703] Excluded '.DS_Store' files from the image build context.
AlexSkrypnyk b5421ef
Updated snapshots.
AlexSkrypnyk d4feb4c
[#2703] Ignored scaffold README files instead of disabling their scaf…
AlexSkrypnyk 9e6618a
[#2703] Removed '.gitignore' migration assertions from the installer …
AlexSkrypnyk 684ce84
Updated snapshots.
AlexSkrypnyk 4f44579
[#2703] Reworded the scaffold comment to survive tool-removal scrubbing.
AlexSkrypnyk 2789e14
Updated snapshots.
AlexSkrypnyk 3c49dbd
Re-triggered CI to clear a flaky check.
AlexSkrypnyk 29a05f8
[#2703] Turned '.gitignore.artifact' into a deny list.
AlexSkrypnyk 97a0a57
Updated snapshots.
AlexSkrypnyk 2ecd85a
[#2703] Aligned '.dockerignore' and '.gitignore.artifact' section ord…
AlexSkrypnyk f00b123
Updated snapshots.
AlexSkrypnyk 5e6b33b
[#2703] Reconciled wildcard and anchoring patterns across the ignore …
AlexSkrypnyk cada4d7
Updated snapshots.
AlexSkrypnyk fc7bab5
[#2703] Excluded CI cache-key files, in-tree harness and dev configs …
AlexSkrypnyk 3a26cda
Updated snapshots.
AlexSkrypnyk bd2b288
[#2703] Fenced dev-only and CI-provider-specific artifact exclusions.
AlexSkrypnyk 62e4c0a
Updated snapshots.
AlexSkrypnyk 95d1e65
Updated snapshots.
AlexSkrypnyk aa35ba0
[#2703] Documented the deny-list ignore files, one section per file.
AlexSkrypnyk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,73 +1,57 @@ | ||
| # Ignore everything but a whitelist of files. | ||
| # Deny list of paths excluded from the container image build context. | ||
| # Everything not listed here is included into the image. | ||
| # | ||
| # It is very important to only add production assets to the container during | ||
| # the build. Adding anything else, like tests files or packages, has potential | ||
| # security implications. | ||
|
|
||
| # Ignore everything. | ||
| * | ||
|
|
||
| # Do not ignore web. | ||
| #; @todo: Add support for renamed web. | ||
| !web | ||
|
|
||
| # Do not ignore config. | ||
| !config | ||
|
|
||
| # Do not ignore recipes. | ||
| !recipes | ||
|
|
||
| # But still ignore Drupal directories generated by Composer. | ||
| # Never let VCS internals, secrets, local overrides, database dumps or | ||
| # host-installed dependencies enter the image: they leak data, bloat the | ||
| # context and override the in-image build results. | ||
|
|
||
| # VCS, IDE and OS files. | ||
| .git | ||
| .idea | ||
| .vscode | ||
| **/.DS_Store | ||
|
|
||
| # Local override files - may contain credentials. | ||
| .env.local | ||
| .ahoy.local.yml | ||
| docker-compose.override.yml | ||
| web/sites/*/settings.local.php | ||
| web/sites/*/services.local.yml | ||
|
|
||
| # Local data, logs, caches and temporary artifacts. | ||
| .artifacts | ||
| .data | ||
| .logs | ||
| .phpunit.cache | ||
| .twig-cs-fixer.cache | ||
|
|
||
| # Dependencies are installed during the image build. | ||
| vendor | ||
| node_modules | ||
| web/themes/**/node_modules | ||
|
|
||
| # Drupal directories generated by Composer during the image build. | ||
| web/core | ||
| web/libraries | ||
| web/modules/contrib | ||
| web/themes/contrib | ||
| web/profiles/contrib | ||
| web/libraries | ||
| !drush | ||
| drush/contrib/ | ||
| web/themes/contrib | ||
| drush/Commands/contrib | ||
|
|
||
| # Do not ignore other required files. | ||
| !.circleci | ||
| !.docker/config | ||
| !.docker/scripts | ||
| !.env | ||
| !.eslintignore | ||
| !.eslintrc.json | ||
| !.prettierignore | ||
| !.prettierrc.json | ||
| !.sass-lint.yml | ||
| !.stylelintrc.js | ||
| !.twig-cs-fixer.php | ||
| !auth.json | ||
| !behat.yml | ||
| !composer.json | ||
| !composer.lock | ||
| !gherkinlint.json | ||
| !jest.config.js | ||
| !package-lock.json | ||
| !package.json | ||
| !patches | ||
| !patches.lock.json | ||
| !phpcs.xml | ||
| !phpstan.neon | ||
| !phpunit.xml | ||
| !postcss.config.js | ||
| !rector.php | ||
| !scripts | ||
| !tests | ||
| !yarn.lock | ||
| # Content files and test artifacts. | ||
| web/sites/*/files | ||
| web/sites/simpletest | ||
|
|
||
| #;< HOSTING_ACQUIA | ||
| !hooks | ||
| #;> HOSTING_ACQUIA | ||
| #;< HOSTING_LAGOON | ||
| !.lagoon.env.* | ||
| #;> HOSTING_LAGOON | ||
| # Theme build assets are compiled during the image build. | ||
| web/themes/**/build | ||
|
|
||
| #;< VORTEX_DEV | ||
| # In-tree tooling package; consumer sites get it from packagist. | ||
| !.vortex | ||
| # In-tree test harness; consumer sites get tooling from packagist. | ||
| .vortex/* | ||
| !.vortex/tooling | ||
| .vortex/tooling/tests | ||
| .vortex/tooling/playground | ||
| .vortex/tooling/vendor | ||
| .vortex/tooling/.logs | ||
| .vortex/tooling/.phpunit.cache | ||
| #;> VORTEX_DEV |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83 changes: 36 additions & 47 deletions
83
.vortex/installer/tests/Fixtures/handler_process/_baseline/.dockerignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,57 +1,46 @@ | ||
| # Ignore everything but a whitelist of files. | ||
| # Deny list of paths excluded from the container image build context. | ||
| # Everything not listed here is included into the image. | ||
| # | ||
| # It is very important to only add production assets to the container during | ||
| # the build. Adding anything else, like tests files or packages, has potential | ||
| # security implications. | ||
| # Never let VCS internals, secrets, local overrides, database dumps or | ||
| # host-installed dependencies enter the image: they leak data, bloat the | ||
| # context and override the in-image build results. | ||
|
|
||
| # Ignore everything. | ||
| * | ||
| # VCS, IDE and OS files. | ||
| .git | ||
| .idea | ||
| .vscode | ||
| **/.DS_Store | ||
|
|
||
| # Do not ignore web. | ||
| !web | ||
| # Local override files - may contain credentials. | ||
| .env.local | ||
| .ahoy.local.yml | ||
| docker-compose.override.yml | ||
| web/sites/*/settings.local.php | ||
| web/sites/*/services.local.yml | ||
|
|
||
| # Do not ignore config. | ||
| !config | ||
| # Local data, logs, caches and temporary artifacts. | ||
| .artifacts | ||
| .data | ||
| .logs | ||
| .phpunit.cache | ||
| .twig-cs-fixer.cache | ||
|
|
||
| # Do not ignore recipes. | ||
| !recipes | ||
| # Dependencies are installed during the image build. | ||
| vendor | ||
| node_modules | ||
| web/themes/**/node_modules | ||
|
|
||
| # But still ignore Drupal directories generated by Composer. | ||
| # Drupal directories generated by Composer during the image build. | ||
| web/core | ||
| web/libraries | ||
| web/modules/contrib | ||
| web/themes/contrib | ||
| web/profiles/contrib | ||
| web/libraries | ||
| !drush | ||
| drush/contrib/ | ||
| web/themes/contrib | ||
| drush/Commands/contrib | ||
|
|
||
| # Content files and test artifacts. | ||
| web/sites/*/files | ||
| web/sites/simpletest | ||
|
|
||
| # Do not ignore other required files. | ||
| !.circleci | ||
| !.docker/config | ||
| !.docker/scripts | ||
| !.env | ||
| !.eslintignore | ||
| !.eslintrc.json | ||
| !.prettierignore | ||
| !.prettierrc.json | ||
| !.sass-lint.yml | ||
| !.stylelintrc.js | ||
| !.twig-cs-fixer.php | ||
| !auth.json | ||
| !behat.yml | ||
| !composer.json | ||
| !composer.lock | ||
| !gherkinlint.json | ||
| !jest.config.js | ||
| !package-lock.json | ||
| !package.json | ||
| !patches | ||
| !patches.lock.json | ||
| !phpcs.xml | ||
| !phpstan.neon | ||
| !phpunit.xml | ||
| !postcss.config.js | ||
| !rector.php | ||
| !scripts | ||
| !tests | ||
| !yarn.lock | ||
| # Theme build assets are compiled during the image build. | ||
| web/themes/**/build |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.