webhook: add idempotency check and configurable unix socket path#31
Open
pmady wants to merge 1 commit into
Open
webhook: add idempotency check and configurable unix socket path#31pmady wants to merge 1 commit into
pmady wants to merge 1 commit into
Conversation
pmady
requested review from
ClementMaH,
CormickKneey,
LunaWhispers,
anjia0532,
gaius-qi and
yyzai384
- Add dragonfly.io/injected annotation to prevent double injection - Make unix socket path configurable via Config.UnixSockPath field - Fall back to default /var/run/dragonfly/dfdaemon.sock when empty - Add tests for configurable socket path and idempotency - Update default ConfigMap with unixSockPath field Ref: dragonflyoss/dragonfly#4416 Signed-off-by: pmady <pavan4devops@gmail.com>
pmady
force-pushed
the
refactor/idempotency-configurable-socket-metrics
branch
from
a64cf25 to
25dd45f
Compare
Author
|
Hi friendly ping on this PR. It's been open for about 2 weeks now. Quick summary of what it does (ref: dragonflyoss/dragonfly#4416):
The branch is cleanly rebased on the latest Is there anything you'd like me to change or split up before merging? Happy to address any feedback. |
Author
|
@gaius-qi bump on this one too when you get a chance - adds the idempotency check we discussed plus makes the unix socket path configurable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Part of dragonflyoss/dragonfly#4416. Adds idempotency check (dragonfly.io/injected annotation) to prevent double injection, makes unix socket path configurable via InjectConf, and adds tests.
Ref: dragonflyoss/dragonfly#4416