Minor fixes for the nvmf module - #2564
Open
aafeijoo-suse wants to merge 2 commits into
Open
Conversation
`set -- $1` reassigns the positional parameters, so when the warning message is printed, "$1" does not contain anymore all the arguments passed via `rd.nvmf.discover=`. Follow-up for 2f03d69
github-actions
Bot
added
modules
devkontrol
previously approved these changes
Aug 5, 2026
bdrung
requested changes
Aug 5, 2026
`nbft_run_jq()` defaults to `jq -e`, which exits 1 whenever the last output is null or false, so a malformed JSON with a missing or null ".hfi" field continues the loop without incrementing the `$j` index used in the exit condition. Fixes b490f6f
devkontrol
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits.
Checklist