Fix duplicate _start offset in Tensor.Resize#128511
Open
prozolic wants to merge 2 commits into
Open
Conversation
Fix the offset used when creating a ReadOnlySpan<T> that starts at _start in Tensor.Resize. AsTensorSpan()._reference already includes the _start offset, so applying it again via Unsafe.Add caused the span to start at the wrong position.
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes a bug in Tensor.Resize where the source span incorrectly included data before the tensor's _start offset, causing wrong values to be copied when resizing a tensor created with a non-zero start.
Changes:
- Replaced manual
_start-offset span creation withAsReadOnlyTensorSpan()._referenceand usedFlattenedLengthas the span length. - Added a new test
TensorResizeWithStartTestscovering resize cases for a tensor created with a non-zerostart.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/Tensor.cs | Corrects source span reference and length for dense tensor resize. |
| src/libraries/System.Numerics.Tensors/tests/TensorTests.cs | Adds test coverage for Resize on tensors with a non-zero start. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-numerics-tensors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #128512
This PR fix the offset used when creating a
ReadOnlySpan<T>that starts at_startinTensor.Resize.AsTensorSpan()._referencealready includes the_startoffset, so applying it again viaUnsafe.Addcaused the span to start at the wrong position.Changes:
Unsafe.Addwhen creating aReadOnlySpan<T>tensor.AsTensorSpantoTensor.AsReadOnlyTensorSpanto matchTensor.ResizeTo(int)tensor.FlattenedLengthinstead oftensor._values.Length - tensor._start